feat: stop using @Array<T> in snforge_std and use Span<T> instead

[enitrat]

Which component is your feature related to?

Forge

Feature Request

    fn deploy_at(
        self: @ContractClass,
        constructor_calldata: @Array::<felt252>,
        contract_address: ContractAddress
    ) -> SyscallResult<(ContractAddress, Span<felt252>)>;

This should not take @Array<felt252> as argument for the constructor calldata, but Span<felt252>. Span has more methods, it is convertible from a fixed-size array, and with the visibility attributes from the latest releases, we cant convert a span to @Array. There are other functions that need to be changed as well.

[onlydustapp]

Hey @ScottyDavies!
Thanks for showing interest.
We've created an application for you to contribute to Starknet Foundry2.
Go check it out on OnlyDust!

[onlydustapp]

Hey @ScottyDavies!
Thanks for showing interest.
We've created an application for you to contribute to Starknet Foundry.
Go check it out on OnlyDust!

[onlydustapp]

The maintainer Arcticae has assigned ScottyDavies to this issue via OnlyDust Platform.
Good luck!

[Arcticae]

@ScottyDavies unassigning since there is a PR ready

[casweeney]

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a software engineer with strong technical skills and expertise in writing complex scalable applications. I have written and tested some advanced Cairo and Solidity smart contracts like building and testing the Synthetix staking contract using Cairo: https://github.com/casweeney/cairo-synthentix-staking. I have also built some great tools with Rust.

I have contributed to some groundbreaking protocols like Hyperbridge: https://github.com/polytope-labs/hyperbridge/graphs/contributors and my GitHub account has a lot of proof of work.

Leveraging on my skills and experience, I am confident in my ability to tackle new challenges and also solve complex technical issues.

How I plan on tackling this issue

I have already traced the underlying deploy_at function in the deploy.rs file and I can see that it takes an argument calldata of type &[felt252].

I will further study the codebase to fully understand where the deploy_at function is used and I will make necessary modifications for it to use Span<T> instead of Array<T>.

[Arcticae]

@casweeney we are waiting with those changes for some bigger upgrade
cc @cptartur what's our strategy on this one?

[enitrat]

it's done in #2396 already

[casweeney]

it's done in #2396 already

Alright, thanks.

[PedroRosalba]

Can I tackle this one?

[hannahredler]

Hey! I'm Hannah, a full stack developer with 6+ years experience but new to the starknet ecosystem. I would love to give this a go if its available!