Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy contract by name #2279

Open
Arcticae opened this issue Jul 5, 2024 · 0 comments · May be fixed by #2331
Open

Deploy contract by name #2279

Arcticae opened this issue Jul 5, 2024 · 0 comments · May be fixed by #2331
Assignees
Labels
feature New feature request/description sncast

Comments

@Arcticae
Copy link
Contributor

Arcticae commented Jul 5, 2024

Which components does the task require to be changed? (think hard pls)

sncast

Description

Sometimes a user wants to deploy from cast without previous declaration. We should detect if the contract was declared (and declare it if it's not done already), and then deploy it when --contract-name is passed to deploy instead of --class-hash.

Recompilation and recalculating hash every time it's executed, will be necessary to make it work (we have to check if it's actually the same).

This should probably include some verbosity about transactions that are actually made during the process.

@Arcticae Arcticae added the sncast label Jul 5, 2024
@Arcticae Arcticae added this to the Cast UX improvements milestone Jul 5, 2024
@github-actions github-actions bot added the new label Jul 5, 2024
@piotmag769 piotmag769 added the feature New feature request/description label Jul 5, 2024
@Arcticae Arcticae moved this from Triage to Backlog in Starknet foundry Jul 5, 2024
@integraledelebesgue integraledelebesgue linked a pull request Jul 24, 2024 that will close this issue
5 tasks
@Arcticae Arcticae moved this from Backlog to In Progress in Starknet foundry Jul 29, 2024
@cptartur cptartur moved this from In Review to In Progress in Starknet foundry Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request/description sncast
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

5 participants