Fix determining version (#32)

* Add `console.log`

* Fix resolving scarb version

* Change version in `Test local action`

* Remove windows from os matrix

* Remove running tests on windows

* Run `npm run build`

* Simplify `determineVersion`

* Remove running tests on Windows

* Fix variable name

* Fix resolving scarb version

* Another console.log

* Update console.log

* Update console.log

* Add console.log

* More logs

* More logs

* Logs

* Refactor `action.yml`

* Little changes

* Fix `determineVersion`

* Include USC setup

* Add envs in `action.yml`

* Code cleanup

* Run `npm run build`

* Remove console logs

* Add console.log

* Add test for fixed version

* Little refactor for fixed version validation

* Formatting

* Temporarily change fixed version to make workflow fail

* Refactor `Verify snforge version`

* Restore correct version

* Run `npm run build`

* Refactor

* Use `actions/checkout@v4` instead of v3

* Trigger CI

* Temporarily change way, how  `StarknetFoundryVersionInput` is determined

* Formatting

* Formatting

* Revert "Formatting"

This reverts commit 43da8b8.

* Add `workflow_dispatch`

* Trigger CI

* Fix `checks.yml`

* Fix `checks.yml`

* Code cleanup

* Restore previous logic in `determineVersion`

Author: franciszekjob

.github/workflows/check-dist.yml

@@ -22,7 +22,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Set Node.js 20.x
         uses: actions/setup-node@v3

.github/workflows/checks.yml

@@ -13,7 +13,7 @@ jobs:
   lint:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - uses: actions/setup-node@v3
         with:
           node-version: 20.x
@@ -28,7 +28,7 @@ jobs:
   test-action:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Get scarb version
         id: extractScarbVersion
@@ -61,7 +61,7 @@ jobs:
   test-action-with-tools-file:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: "Create .tool-versions file"
         shell: bash
@@ -75,3 +75,31 @@ jobs:
 
       - run: snforge --version | grep "snforge 0.16.0"
         shell: bash
+
+  test-action-with-fixed-version:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: "Setup Scarb"
+        uses: software-mansion/setup-scarb@v1
+        with:
+          scarb-version: 2.9.4
+
+      - name: "Setup foundry using fixed version"
+        uses: ./
+        with:
+          starknet-foundry-version: 0.44.0
+
+      - name: Verify snforge version
+        run: |
+          EXPECTED="snforge 0.44.0"
+          VERSION=$(snforge --version)
+
+          echo "Expected version: $EXPECTED"
+          echo "Actual version:   $VERSION"
+
+          if [[ "$VERSION" != "$EXPECTED" ]]; then
+            echo "Version mismatch"
+            exit 1
+          fi

action.yml

@@ -25,3 +25,6 @@ runs:
     - name: Set up Starknet Foundry
       shell: bash
       run: node $GITHUB_ACTION_PATH/dist/index.js
+      env:
+        INPUT_STARKNET-FOUNDRY-VERSION: ${{ inputs.starknet-foundry-version }}
+        INPUT_TOOL-VERSIONS: ${{ inputs.tool-versions }}

dist/index.js

@@ -29824,12 +29824,12 @@ async function determineVersion(version, toolVersionsPath, repo) {
 
   if (version && toolVersionsPath) {
     throw new Error(
-      "the `starknet-foundry-version` and `tool-versions` inputs cannot be used simultaneously",
+      "`starknet-foundry-version` and `tool-versions` inputs cannot be used simultaneously",
     );
   }
 
   if (toolVersionsPath) {
-    let toolVersion = await getVersionFromToolVersionsFile(toolVersionsPath);
+    const toolVersion = await getVersionFromToolVersionsFile(toolVersionsPath);
 
     if (!toolVersion) {
       throw new Error(
@@ -29840,19 +29840,15 @@ async function determineVersion(version, toolVersionsPath, repo) {
   }
 
   if (!version) {
-    let toolVersion = await getVersionFromToolVersionsFile();
+    const toolVersion = await getVersionFromToolVersionsFile();
     version = toolVersion ?? "latest";
   }
 
   if (version === "latest") {
     version = await fetchLatestTag(repo);
   }
 
-  if (version.startsWith("v")) {
-    version = version.substring(1);
-  }
-
-  return version;
+  return version.startsWith("v") ? version.slice(1) : version;
 }
 
 function fetchLatestTag(repo) {

lib/versions.js

@@ -19,12 +19,12 @@ export async function determineVersion(version, toolVersionsPath, repo) {
 
   if (version && toolVersionsPath) {
     throw new Error(
-      "the `starknet-foundry-version` and `tool-versions` inputs cannot be used simultaneously",
+      "`starknet-foundry-version` and `tool-versions` inputs cannot be used simultaneously",
     );
   }
 
   if (toolVersionsPath) {
-    let toolVersion = await getVersionFromToolVersionsFile(toolVersionsPath);
+    const toolVersion = await getVersionFromToolVersionsFile(toolVersionsPath);
 
     if (!toolVersion) {
       throw new Error(
@@ -35,19 +35,15 @@ export async function determineVersion(version, toolVersionsPath, repo) {
   }
 
   if (!version) {
-    let toolVersion = await getVersionFromToolVersionsFile();
+    const toolVersion = await getVersionFromToolVersionsFile();
     version = toolVersion ?? "latest";
   }
 
   if (version === "latest") {
     version = await fetchLatestTag(repo);
   }
 
-  if (version.startsWith("v")) {
-    version = version.substring(1);
-  }
-
-  return version;
+  return version.startsWith("v") ? version.slice(1) : version;
 }
 
 function fetchLatestTag(repo) {