Skip to content

Conversation

@albertov19
Copy link
Contributor

Motivation

Polkadot is rolling out a REVM backend, but it requires custom gas mapping so gas estimation needs to be done via RPC.

Solution

Adds Polkadot as a named chain that needs gas estimation via RPC call. Goes with alloy-rs/chains#222

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

new chains patch is released so we can bump here as well

| NamedChain::MoonbeamDev
| NamedChain::Moonriver
| NamedChain::Metis
| NamedChain::PolkadotTestnet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is released now, so you can bump in cargo.toml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The toml has 0.2 (no patch), which should include 0.2.18 (tested it locally). I bumped the cargo.lock file tho

@grandizzy grandizzy requested a review from mattsse November 12, 2025 12:52
@grandizzy
Copy link
Collaborator

lgtm, @albertov19 OK to move in ready for review / merge? thanks!

@albertov19
Copy link
Contributor Author

Thanks for the quick turnaround - the REVM backend should be ready next week. I'll mark it ready for review and ping you all by then. You were too quick 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants