-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Polkadot Testnet RPC gas estimation #12537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Polkadot Testnet RPC gas estimation #12537
Conversation
…tov19/foundry into albertov19/polkadot-gas-estimation
mattsse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense
new chains patch is released so we can bump here as well
| | NamedChain::MoonbeamDev | ||
| | NamedChain::Moonriver | ||
| | NamedChain::Metis | ||
| | NamedChain::PolkadotTestnet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is released now, so you can bump in cargo.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The toml has 0.2 (no patch), which should include 0.2.18 (tested it locally). I bumped the cargo.lock file tho
|
lgtm, @albertov19 OK to move in ready for review / merge? thanks! |
|
Thanks for the quick turnaround - the REVM backend should be ready next week. I'll mark it ready for review and ping you all by then. You were too quick 😅 |
Motivation
Polkadot is rolling out a REVM backend, but it requires custom gas mapping so gas estimation needs to be done via RPC.
Solution
Adds Polkadot as a named chain that needs gas estimation via RPC call. Goes with alloy-rs/chains#222
PR Checklist