feat(cast): block -f to accept multiple fields #12427
Open
+54
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dipanshuhappy
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
onbjerg
requested changes
Nov 3, 2025
crates/cast/src/opts.rs
Outdated
Comment on lines
382
to
383
| #[arg(short, long,num_args = 1..,action = ArgAction::Append,value_delimiter = ',')] | ||
| fields: Vec<String>, |
Contributor
There was a problem hiding this comment.
please make sure this is renamed to --field in cast using long = "field" so this is not breaking
Contributor
Author
There was a problem hiding this comment.
please make sure this is renamed to
--fieldincastusinglong = "field"so this is not breaking
Pushed the change
grandizzy
requested changes
Nov 11, 2025
Collaborator
grandizzy
left a comment
grandizzy
left a comment
There was a problem hiding this comment.
Please fix failing tests, thank you
Contributor
Author
Thanks for letting me know on that, I had the assumption that I shouldn't edit existing test cases, but I have pushed some 2 edited test cases, that were failing due to whitespace. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolvs #12385
Solution
Basically I changed it
fieldtofields, type toVec<String>. Then loops over the fields and appends the output to the final std out stream.PR Checklist