Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove regex argument of forge test --debug and --decode-internal #8931

Open
Tracked by #8574
DaniPopes opened this issue Sep 22, 2024 · 2 comments · May be fixed by #9572
Open
Tracked by #8574

chore: remove regex argument of forge test --debug and --decode-internal #8931

DaniPopes opened this issue Sep 22, 2024 · 2 comments · May be fixed by #9572
Labels
C-forge Command: forge Cmd-forge-test Command: forge test T-chore Type: chore T-likely-breaking Type: requires changes that can be breaking
Milestone
v1.0.0

Comments

@DaniPopes
Copy link
Member

Component

Forge

Describe the feature you would like

These are deprecated in #8930 and should be removed for 1.0

cc @zerosnacks do we track deprecations to be removed anywhere?

Additional context

No response
@DaniPopes DaniPopes added the T-feature Type: feature label Sep 22, 2024
@DaniPopes DaniPopes added this to the v1.0.0 milestone Sep 22, 2024
@zerosnacks zerosnacks mentioned this issue Sep 23, 2024
Open
13 tasks
@zerosnacks zerosnacks added the T-likely-breaking Type: requires changes that can be breaking label Sep 23, 2024
@zerosnacks zerosnacks changed the title Remove regex argument of forge test --debug and --decode-internal chore: remove regex argument of forge test --debug and --decode-internal Sep 23, 2024
@zerosnacks zerosnacks added Cmd-forge-test Command: forge test C-forge Command: forge labels Sep 23, 2024
@zerosnacks
Copy link
Member

do we track deprecations to be removed anywhere?

added it to #8574 in the post 1.0 breaking changes section

@zerosnacks zerosnacks added T-chore Type: chore and removed T-feature Type: feature labels Oct 1, 2024
@grandizzy grandizzy removed this from the v1.0.0 milestone Oct 1, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Oct 1, 2024
@DaniPopes DaniPopes added this to the v1.0.0 milestone Oct 20, 2024
@DaniPopes
Copy link
Member Author

This should be done for 1.0, not after, since it's the removal of a deprecation.

@grandizzy grandizzy mentioned this issue Nov 15, 2024
Closed
2 tasks
@yash-atreya yash-atreya linked a pull request Dec 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-forge Command: forge Cmd-forge-test Command: forge test T-chore Type: chore T-likely-breaking Type: requires changes that can be breaking
Projects
Foundry
Archived in project
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

[DO NOT MERGE] chore(forge): rm regex for --debug and --decode-internal foundry-rs/foundry
3 participants
@grandizzy @DaniPopes @zerosnacks