Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: FOUNDRY_ENV set to CI should automatically install with --no-commit #9557

Open
sambacha opened this issue Dec 14, 2024 · 0 comments
Open
Labels
A-dependencies Area: dependencies T-feature Type: feature

Comments

@sambacha
Copy link
Contributor

sambacha commented Dec 14, 2024

Component

Forge

Describe the feature you would like

If we are in a detected CI environment, it makes sense not to want to commit install dependencies outside those defined already in the existing .gitmodules file. CI environment typically does not even have the correct git config user/author setup anyway. Plus, it makes sense that we want to keep the work tree clean in testing matrix/scenarios/etc.

Additional context

GitHub runners do not have user/author setup, and its a CI env.

Note

Edit: Since the Runner isn't configured with GIT_AUTHOR or GIT_USER, we must explicitly set these in order to run forge install. Instead, why not just detect CI=true and automatically use --no-commit or alternatively if GIT_AUTHOR env is unset (i.e. GIT_AUTHOR='' it will use --no-commit.)

@sambacha sambacha added T-feature Type: feature T-needs-triage Type: this issue needs to be labelled labels Dec 14, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Dec 14, 2024
@zerosnacks zerosnacks added A-dependencies Area: dependencies and removed T-needs-triage Type: this issue needs to be labelled labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: dependencies T-feature Type: feature
Projects
Status: Todo
Development

No branches or pull requests

2 participants