Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: turn forge coverage and forge snapshot into forge test flags (--coverage, --snapshot) #9528

Open
zerosnacks opened this issue Dec 10, 2024 · 1 comment
Open

chore: turn forge coverage and forge snapshot into forge test flags (--coverage, --snapshot) #9528

zerosnacks opened this issue Dec 10, 2024 · 1 comment
Labels
A-internals Area: internals T-chore Type: chore T-likely-breaking Type: requires changes that can be breaking T-to-discuss Type: requires discussion

Comments

@zerosnacks
Copy link
Member

zerosnacks commented Dec 10, 2024 •
edited
Loading

Component

Forge

Describe the feature you would like

Proposal: merge forge coverage and forge snapshot into forge test, expose them with feature flags (--coverage, --snapshot). This is in line with other reports like --gas-report.

This would simplify forge test compatibility issues described in #9525 and make it easier to flag incompatible flags (current limitation because of TestArgs inheritance)

We should also refactor run_tests method in forge test into helpers

This is a significant breaking change for scripted workflows i.e. https://github.com/atarpara/foundry-snapshot-diff and CI's of users.
@zerosnacks zerosnacks added A-internals Area: internals T-likely-breaking Type: requires changes that can be breaking T-chore Type: chore labels Dec 10, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Dec 10, 2024
@zerosnacks zerosnacks added the T-to-discuss Type: requires discussion label Dec 10, 2024
@zerosnacks
Copy link
Member Author

zerosnacks commented Dec 10, 2024 •
edited
Loading

Alternatively we could avoid inheriting TestArgs in coverage and implement a subset - like ScriptArgs does and implement a subset of run_tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-internals Area: internals T-chore Type: chore T-likely-breaking Type: requires changes that can be breaking T-to-discuss Type: requires discussion
Projects
Foundry
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zerosnacks