Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECDSA signature generation does not follow RFC-6979 #9499

Open
pmerkleplant opened this issue Dec 5, 2024 · 0 comments
Open

ECDSA signature generation does not follow RFC-6979 #9499

pmerkleplant opened this issue Dec 5, 2024 · 0 comments
Labels
A-dependencies Area: dependencies T-chore Type: chore

Comments

@pmerkleplant
Copy link

The ECDSA signatures generated by the vm.sign() cheatcode do not strictly follow RFC-6979. For more info regarding the details, see this analysis.

Note that the underlying ECDSA functionality is provided via RustCrypto which fixed the issue in a recent prerelease, see RustCrypto/elliptic-curves#1100.

Creating this as tracking issue, can be closed once foundry updates to the new RustCrypto version.
@DaniPopes DaniPopes transferred this issue from foundry-rs/forge-std Dec 5, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Dec 5, 2024
@DaniPopes DaniPopes added A-dependencies Area: dependencies T-chore Type: chore labels Dec 5, 2024
@zerosnacks zerosnacks modified the milestone: v1.0.0 Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-dependencies Area: dependencies T-chore Type: chore
Projects
Foundry
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DaniPopes @pmerkleplant @zerosnacks