Impact by Etherscan's lack of error on Reinit issues

[Hellobloc]

Introduction

Foundry will not recognize this problem when meet a reinit contract. This is mainly because the data returned by the Etherscan API does not provide any error information for reinit, although this waring information is displayed on the etherscan web page. But it is worth noting that all API-dependent tools have been impact.

Details

https://api-sepolia.etherscan.io/api?module=contract&action=getsourcecode&address=0x9fB39EE8a5879DC788a525D29C596b9BBBE9f5A4&apikey=HEGX18IPPBPB9M23C4W1UDNP5I4F57XX1F

https://sepolia.etherscan.deth.net/address/0x9fB39EE8a5879DC788a525D29C596b9BBBE9f5A4

https://sepolia.etherscan.io/address/0x9fB39EE8a5879DC788a525D29C596b9BBBE9f5A4#code

Impact

It is worth noting that this problem will cause the user to obtain a source code that does not match the current bytecode. Because the target contract may be created using create2 and after verification is completed, another bytecode is deployed.

Ethic Things

i already report the reinit issue in API feedback in 2 year ago. but etherscan don't give any feedback. so i think i should report to the user of this api.

[zerosnacks]

Considering selfdestruct() now behaves differently and contracts can no longer be reinitialized (metamorphic smart contracts) I think this has become a low priority for Etherscan to index historical contracts that do this. On the Foundry side we are reliant on the Etherscan API to report this correctly. For now closing as not planned.

[Hellobloc]

The Selfdestuct problem is not applied in all EVMs. Secondly, the contracts that already existed before can still construct this impact. I think if you think engineering implementation requires a lot of bad introductions, you can consider giving warnings in the documentation.

[Hellobloc]

@zerosnacks

[Hellobloc]

And don't try to find a reason for etherscan that is not the case at all. When I reported this problem, geth don't modify the actual operation of selfdestruct. Don't make your irresponsibility sound so good.

[zerosnacks]

We are reliant on Etherscan to report this correctly but I'm open to a contribution to document this as an edge case in the Foundry book

cc @0xV4L3NT1N3