feat(forge): no warning on external config sections (#11869)

feat(forge): no warning on external sections

Author: grandizzy

crates/config/src/lib.rs

@@ -679,6 +679,9 @@ impl Config {
     /// TOML section for profiles
     pub const PROFILE_SECTION: &'static str = "profile";
 
+    /// External config sections, ignored from warnings.
+    pub const EXTERNAL_SECTION: &'static str = "external";
+
     /// Standalone sections in the config which get integrated into the selected profile
     pub const STANDALONE_SECTIONS: &'static [&'static str] = &[
         "rpc_endpoints",

crates/config/src/providers/warnings.rs

@@ -48,6 +48,7 @@ impl<P: Provider> WarningsProvider<P> {
             data.keys()
                 .filter(|k| {
                     **k != Config::PROFILE_SECTION
+                        && **k != Config::EXTERNAL_SECTION
                         && !Config::STANDALONE_SECTIONS.iter().any(|s| s == k)
                 })
                 .map(|unknown_section| {

crates/forge/tests/cli/config.rs

@@ -1924,3 +1924,24 @@ Warning: Key `deny_warnings` is being deprecated in favor of `deny = warnings`.
 
 "#]]);
 });
+
+// <https://github.com/foundry-rs/foundry/issues/5866>
+forgetest!(no_warnings_on_external_sections, |prj, cmd| {
+    cmd.git_init();
+
+    let toml = r"[profile.default]
+    src = 'src'
+    out = 'out'
+
+    # Custom sections for other tools
+    [external.scopelint]
+    some_flag = 1
+
+    [external.forge_deploy]
+    another_setting = 123";
+
+    fs::write(prj.root().join("foundry.toml"), toml).unwrap();
+    cmd.forge_fuse().args(["config"]).assert_success().stderr_eq(str![[r#"
+
+"#]]);
+});