fix: normalize path separators in git submodule URL lookup (#11826)

* fix: normalize path separators in git submodule URL lookup

* make ci happy

* fix fmt

* use dunce::canonicalize

* removed the path separator replacement and now rely only on `dunce::canonicalize`

* Update proper test

* Fix

---------

Co-authored-by: grandizzy <[email protected]>

Author: wellnana

Cargo.lock

@@ -42,6 +42,7 @@ futures.workspace = true
 indicatif.workspace = true
 itertools.workspace = true
 mimalloc = { workspace = true, optional = true }
+path-slash.workspace = true
 rayon.workspace = true
 regex = { workspace = true, default-features = false }
 serde_json.workspace = true

crates/cli/Cargo.toml

@@ -8,6 +8,7 @@ use foundry_common::{
 };
 use foundry_config::{Chain, Config};
 use itertools::Itertools;
+use path_slash::PathExt;
 use regex::Regex;
 use serde::de::DeserializeOwned;
 use std::{
@@ -718,13 +719,9 @@ ignore them in the `.gitignore` file."
     }
 
     /// Get the URL of a submodule from git config
-    pub fn submodule_url(self, path: impl AsRef<OsStr>) -> Result<Option<String>> {
+    pub fn submodule_url(self, path: &Path) -> Result<Option<String>> {
         self.cmd()
-            .args([
-                "config",
-                "--get",
-                &format!("submodule.{}.url", path.as_ref().to_string_lossy()),
-            ])
+            .args(["config", "--get", &format!("submodule.{}.url", path.to_slash_lossy())])
             .get_stdout_lossy()
             .map(|url| Some(url.trim().to_string()))
     }

crates/cli/src/utils/mod.rs

@@ -33,7 +33,6 @@ impl RemoveArgs {
         let config = self.load_config()?;
         let (root, paths, _) = super::update::dependencies_paths(&self.dependencies, &config)?;
         let git_modules = root.join(".git/modules");
-
         let git = Git::new(&root);
         let mut lockfile = Lockfile::new(&config.root).with_git(&git);
         let _synced = lockfile.sync(config.install_lib_dir())?;

crates/forge/src/cmd/remove.rs

@@ -108,10 +108,9 @@ Installing forge-std in [..] (url: Some("https://github.com/foundry-rs/forge-std
     };
 
     let remove = |cmd: &mut TestCommand, target: &str| {
-        // TODO: flaky behavior with URL, sometimes it is None, sometimes it is Some("https://github.com/lib/forge-std")
         cmd.forge_fuse().args(["remove", "--force", target]).assert_success().stdout_eq(str![[
             r#"
-Removing 'forge-std' in [..], (url: [..], tag: None)
+Removing 'forge-std' in [..], (url: Some("https://github.com/foundry-rs/forge-std"), tag: None)
 
 "#
         ]]);