Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit hook prevents workshops with common words #960

Open
oliverjam opened this issue May 7, 2024 · 1 comment
Open

Pre-commit hook prevents workshops with common words #960

oliverjam opened this issue May 7, 2024 · 1 comment

Comments

@oliverjam
Copy link
Contributor

This is probably my fault since I suggested adding a markdown linter in #467, but the Alex setup appears to be a bit too strict. I assume no one has tried to commit new workshops in a while, because the pre-commit hook blocks commits for "warnings" in content like:

Be careful with `reject`, it’s profane in some cases
Be careful with `crash`, it’s profane in some cases
Be careful with `execute`, it’s profane in some cases
`invalid` may be insensitive
`just` may be insensitive, try not to use it

It's pretty hard to talk about code without these words 😅. I ran Alex on the whole workshop folder and nearly every file would technically be failing now.

I can bypass the hook for the workshop I'm currently writing but it might be a good idea for someone to look into maybe making warnings not a failure?

@oliverjam
Copy link
Contributor Author

Ha it runs on CSS files too

Be careful with `color`, it’s profane in some cases
`white-space` may be insensitive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant