Skip to content
This repository has been archived by the owner on Oct 9, 2020. It is now read-only.

Adding Kotlin Support #2357

Open
sriramr98 opened this issue Mar 7, 2018 · 12 comments
Open

Adding Kotlin Support #2357

sriramr98 opened this issue Mar 7, 2018 · 12 comments

Comments

@sriramr98
Copy link
Contributor

Steps to reproduce it
Kotlin is an awesome language that introduces verbosity and conciseness for the project. Adding Kotlin support to the project will improve the quality of the code with significantly reduced codebase. I would like to start by adding kotlin in incremental builds - one fragment at a time.

Would you like to work on the issue?

Yes. I would like to work on this issue

Target Milestone to solve the issue
I would like to take this up for GSOC 2018 as a milestone.

@the-dagger
Copy link
Member

@sriramr98 I think you can go ahead with converting one Pojo to Kotlin and we can review that and merge.
@iamareebjamal Does that sound good, correct me if this is not in our current implementation list?

@sriramr98
Copy link
Contributor Author

I think we should start with converting utility classes instead of a Pojo. There are some small issues with data classes and Realm that needs to be fixed before converting a Pojo. So I think we should start with some Utility Classes.

@iamareebjamal
Copy link
Member

@the-dagger Sounds good, And I agree, utility classes should be converted first as the data layer s already being reworked in this library https://github.com/iamareebjamal/openevent-java

@sriramr98
Copy link
Contributor Author

So I will start converting two-two utility classes at a time

@mayank8318
Copy link
Contributor

@sriramr98 Would you like to split up?

@sriramr98
Copy link
Contributor Author

@mayank8318 I'm sorry man, I'm trying to include this as a small part of my GSoC proposal. If I don't get selected for it, then we can split up the work, collab and get the job done.

@iamareebjamal
Copy link
Member

The PR does not solve this issue as this issue will be closed when entire project is completely converted to kotlin

@sriramr98
Copy link
Contributor Author

@iamareebjamal Can we continue with this issue? Should we start with some util classes or start refactoring activities?

@iamareebjamal
Copy link
Member

Util classes first

@sriramr98
Copy link
Contributor Author

Alright. Ill push two util classes a day and we'll see how it goes.

@sriramr98
Copy link
Contributor Author

@iamareebjamal the utility classes have been converted. What next?

@iamareebjamal
Copy link
Member

Convert non android specific classes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants