Skip to content
This repository has been archived by the owner on Oct 9, 2020. It is now read-only.

Events bookmarked on Schedule does not update the DayFragmentSchedule #2352

Open
leeyh20 opened this issue Feb 25, 2018 · 6 comments
Open

Events bookmarked on Schedule does not update the DayFragmentSchedule #2352

leeyh20 opened this issue Feb 25, 2018 · 6 comments
Labels

Comments

@leeyh20
Copy link
Contributor

leeyh20 commented Feb 25, 2018

Actual Behaviour
Adding a bookmark on an event won't update DayFragmentSchedule

Expected Behaviour

Adding a bookmark on an event should update DayFragmentSchedule

Steps to reproduce it

  1. Go to DayFragmentSchedule at "Schedule"
  2. Click any event like "Coffee Break" to see its details
  3. Bookmark the event
  4. Exit the event details view
  5. DayFragmentSchedule at "Schedule" does not show that the event has been bookmarked.

Screenshots of the issue
bookmark

Would you like to work on the issue?

Yes but I think it might be related to #2318

@iamareebjamal Is this an related issue to #2318 ?

@iamareebjamal
Copy link
Member

No, it is different

@leeyh20
Copy link
Contributor Author

leeyh20 commented Feb 25, 2018

@iamareebjamal Ok thanks I'll try to look into it!

@sriramr98
Copy link
Contributor

Is anyone working on this? I have fixed the bug and added some kotlin support. This might have also fixed issue #2318 . If no one has a solution, I would like to send a PR.

@leeyh20
Copy link
Contributor Author

leeyh20 commented Mar 8, 2018

@sriramr98 You can go ahead and send a PR for this issue! Sorry, was busy with school!

@iamareebjamal
Copy link
Member

iamareebjamal commented Mar 8, 2018

@sriramr98 If you do fix this, please be aware that we appreciate single PR per issue. Your PR may fix two related issues but not tackle a new one

@sriramr98
Copy link
Contributor

Okay. My PR will only fix this current issue. I will work on the related issue separately.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants