-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Badge Overlapping And Icon #1954
Conversation
a7f4082
to
047b033
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sk9331657 Changing the footer as a whole is not needed. We need to display other projects of fossasia in the footer also. A better solution to the problem would be to lock the scroll of preview section just at the top of footer rather than changing the footer completely.
@ParthS007 @gabru-md @mariobehling @yashLadha Reviews please
@mariobehling Please review this pr . This will fix footer and increase preview area. |
Please don't overlap the footer over the badge. |
@mariobehling I have resolved overlapping in this pr. |
The idea would be that as soon as the footer is close to the badge, that the badge just moves up as well. |
Ok I will do that way. |
@mariobehling For time being this pr can fix overlapping . I will fix the remaining bug in other pr. |
The thing is that, if we merge this, a new bug arises that should be solved in another making this PR obsolete. Instead try to solve the issue here itself. :) |
@sk9331657 Would be great, if you could finalize this PR @abishekvashok pointed out. Thank you. |
Will surely fix this. Busy in making Google Summer of Code proposal right now. Application period is coming near. |
c12e075
to
8d0d027
Compare
@abishekvashok @mariobehling @gabru-md @yashLadha @ParthS007 Finalised the pr. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sk9331657 The bug was to remove the overlapping, which can also be solved without changing the design of footer. Changing the design if footer is not required.
@rajvaibhavdubey Increasing the height of footer limits the size of badge and restrict size of badge details which is not desired. |
@abishekvashok @gabru-md Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't hard code values, try to use sticky footer
Closing due to inactivity. |
Fixes #1950
Checklist
development
branch.Now