Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Badge Overlapping And Icon #1954

Closed

Conversation

championpaddler
Copy link
Member

@championpaddler championpaddler commented Jan 16, 2019

Fixes #1950

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • I have added necessary documentation (if appropriate)

Now
ezgif com-video-to-gif 9

Copy link
Member

@rajvaibhavdubey rajvaibhavdubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sk9331657 Changing the footer as a whole is not needed. We need to display other projects of fossasia in the footer also. A better solution to the problem would be to lock the scroll of preview section just at the top of footer rather than changing the footer completely.
@ParthS007 @gabru-md @mariobehling @yashLadha Reviews please

@championpaddler
Copy link
Member Author

championpaddler commented Jan 17, 2019

@mariobehling Please review this pr . This will fix footer and increase preview area.

@mariobehling
Copy link
Member

Please don't overlap the footer over the badge.

@championpaddler
Copy link
Member Author

Please don't overlap the footer over the badge.

@mariobehling I have resolved overlapping in this pr.

@mariobehling
Copy link
Member

The idea would be that as soon as the footer is close to the badge, that the badge just moves up as well.

@championpaddler
Copy link
Member Author

The idea would be that as soon as the footer is close to the badge, that the badge just moves up as well.

Ok I will do that way.

@championpaddler
Copy link
Member Author

@mariobehling For time being this pr can fix overlapping . I will fix the remaining bug in other pr.

@abishekvashok
Copy link
Member

The thing is that, if we merge this, a new bug arises that should be solved in another making this PR obsolete. Instead try to solve the issue here itself. :)

@mariobehling
Copy link
Member

@sk9331657 Would be great, if you could finalize this PR @abishekvashok pointed out. Thank you.

@championpaddler
Copy link
Member Author

championpaddler commented Mar 21, 2019

@sk9331657 Would be great, if you could finalize this PR @abishekvashok pointed out. Thank you.

Will surely fix this. Busy in making Google Summer of Code proposal right now. Application period is coming near.

@championpaddler
Copy link
Member Author

Screenshot from 2019-04-12 22-39-23
Screenshot from 2019-04-12 22-39-29

@abishekvashok @mariobehling @gabru-md @yashLadha @ParthS007 Finalised the pr. 😄

Copy link
Member

@rajvaibhavdubey rajvaibhavdubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sk9331657 The bug was to remove the overlapping, which can also be solved without changing the design of footer. Changing the design if footer is not required.

@championpaddler
Copy link
Member Author

@sk9331657 The bug was to remove the overlapping, which can also be solved without changing the design of footer. Changing the design if footer is not required.

@rajvaibhavdubey Increasing the height of footer limits the size of badge and restrict size of badge details which is not desired.

@championpaddler
Copy link
Member Author

@abishekvashok @gabru-md Please review.

Copy link
Member

@abishekvashok abishekvashok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't hard code values, try to use sticky footer

@rajvaibhavdubey
Copy link
Member

Closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Overlapping Badge & Footer
4 participants