Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertical Menu fix #2179

Open
wants to merge 7 commits into
base: development
Choose a base branch
from
Open

Vertical Menu fix #2179

wants to merge 7 commits into from

Conversation

Dishebh
Copy link
Member

@Dishebh Dishebh commented Jan 23, 2020

Fixes #2178

Short description of what this resolves:

Fixed the vertical menu on scroll

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@kushthedude kushthedude changed the base branch from master to development January 25, 2020 12:52
@rajvaibhavdubey
Copy link
Member

@Dishebh Update your branch

@Dishebh
Copy link
Member Author

Dishebh commented Jan 28, 2020

@abishekvashok pls review. Thanks.

@Dishebh
Copy link
Member Author

Dishebh commented Jan 31, 2020

@rajvaibhavdubey pls merge, you have already approved. Thanks

kushthedude
kushthedude requested changes Feb 5, 2020
View reviewed changes
Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No custom CSS strictly. Use semantic UI classes

abishekvashok
abishekvashok suggested changes Feb 5, 2020
View reviewed changes
Copy link
Member

@abishekvashok abishekvashok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use semantic ui classes and avoid custom css

gabru-md
gabru-md reviewed Mar 2, 2020
View reviewed changes
Copy link
Member

@gabru-md gabru-md left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any updates on this?

@Dishebh
Copy link
Member Author

Dishebh commented Mar 2, 2020

@kushthedude removed custom css part.

@maze-runnar
Copy link

@Dishebh please provide GIF after changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabru-md gabru-md gabru-md left review comments

@kushthedude kushthedude kushthedude requested changes

@abishekvashok abishekvashok abishekvashok requested changes

@rajvaibhavdubey rajvaibhavdubey rajvaibhavdubey left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The vertical menu isn't fixed
6 participants
@Dishebh @rajvaibhavdubey @maze-runnar @abishekvashok @gabru-md @kushthedude