Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request cancellation flow error #622

Open
Clasherzz opened this issue Feb 24, 2025 · 1 comment · May be fixed by #624
Open

Request cancellation flow error #622

Clasherzz opened this issue Feb 24, 2025 · 1 comment · May be fixed by #624

Comments

@Clasherzz
Copy link
Contributor

Describe the bug/problem

The request shows request cancelled as response even when its not cancelled in that session .

Steps to Reproduce the bug/problem

Make an endpoint with delayed response. Make a request to it and cancel it . Now make the request to same endpoint once again and close the server before a response is send . You can see that instead of showing error it shows request cancelled.

Expected behavior

Should show the error

Device Info (The device where you encountered this issue)

  • OS: Windows
  • Version:, Windows 11

Flutter Doctor

Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel main, 3.27.0-1.0.pre.438, on Microsoft Windows [Version 10.0.22631.4751], locale en-IN)
[√] Windows Version (Windows 11 or higher, 23H2, 2009)
[√] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
[√] Chrome - develop for the web
[√] Visual Studio - develop Windows apps (Visual Studio Build Tools 2019 16.11.34)
[√] Android Studio (version 2021.3)
[√] VS Code (version 1.97.2)
[√] Connected device (3 available)
[√] Network resources

@Clasherzz Clasherzz added the bug Something isn't working label Feb 24, 2025
@Clasherzz
Copy link
Contributor Author

Clasherzz commented Feb 24, 2025

@ashitaprasad this is because after cancelling and using the same request Id to make the next request causes the client manager to think it has already been cancelled. We need to remove it. Currently manager uses a queue to store cancelled request which doesn't have method to remove using the value. So this means using a set. Solving this would also be a step to resolve multipart cancellation error #607

@Clasherzz Clasherzz linked a pull request Feb 26, 2025 that will close this issue
8 tasks
@ashitaprasad ashitaprasad removed the bug Something isn't working label Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants