Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve current rustls::crypto::tls13::Hkdf implementation #7

Closed
Taowyoo opened this issue Nov 3, 2023 · 0 comments · Fixed by #17
Closed

Improve current rustls::crypto::tls13::Hkdf implementation #7

Taowyoo opened this issue Nov 3, 2023 · 0 comments · Fixed by #17
Assignees
@Taowyoo
Labels
enhancement New feature or request

Comments

@Taowyoo
Copy link
Collaborator

Taowyoo commented Nov 3, 2023

Current implementation of rustls::crypto::tls13::Hkdf is done through rustls::crypto::tls13::HkdfUsingHmac with rustls_mbedcrypto_provider::hmac::Hmac, which is not efficient.

Need to use mbedtls offerred hkdf functions instead. See: https://github.com/fortanix/rust-mbedtls/blob/main/mbedtls-sys/vendor/include/mbedtls/hkdf.h
@Taowyoo Taowyoo self-assigned this Dec 7, 2023
@Taowyoo Taowyoo added the enhancement New feature or request label Dec 7, 2023
@Taowyoo Taowyoo linked a pull request Dec 8, 2023 that will close this issue
Add mbedtls based hkdf #17
Merged
2 tasks
@Taowyoo Taowyoo mentioned this issue Dec 8, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Taowyoo Taowyoo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add mbedtls based hkdf fortanix/rustls-mbedtls-provider
1 participant
@Taowyoo