dcap-ql: Fix length validation logic for quote signatures #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taowyoo
previously approved these changes
Jan 6, 2025
jethrogb
requested changes
Jan 7, 2025
| // `get_quote` C APIs allowing larger than necessary buffer to be | ||
| // allocated to hold the quote. | ||
| data = data.take_prefix(cmp::min(data.len(), sig_len))?; | ||
|
|
There was a problem hiding this comment.
Probably can have a warning log here if data.len() > sig_len?
There was a problem hiding this comment.
I have a better idea, see the new commit.
jethrogb
reviewed
Jan 18, 2025
| /// Parses the `Quote` encoded in `quote`, verifies the signature within the | ||
| /// quote, and returns the parsed quote along with any trailing data that | ||
| /// was not part of the signature. It's up to the caller to decide what to | ||
| /// do with the trailing bytes. |
There was a problem hiding this comment.
This voluntary behavior is not acceptable - the API should such that it's difficult to misuse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #676.