Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid tests depending on external services #297

Open
Taowyoo opened this issue Jul 12, 2023 · 0 comments
Open

Avoid tests depending on external services #297

Taowyoo opened this issue Jul 12, 2023 · 0 comments

Comments

@Taowyoo
Copy link
Collaborator

Taowyoo commented Jul 12, 2023

In current CI, the hyper test targeting external Google's service, it would sometomes failed because of rate limit

But Unit tests really shouldn't rely on external services, especially ones that might rate limit us. Can this test be changed so it runs its own server locally that the test can make requests to? Ideally, the server should use a different network implementation, so something like python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant