Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce no !important in stylelint #61

Open
mkrause opened this issue Dec 18, 2024 · 1 comment
Open

Enforce no !important in stylelint #61

mkrause opened this issue Dec 18, 2024 · 1 comment

Comments

@mkrause
Copy link
Collaborator

mkrause commented Dec 18, 2024

Currently there's a decent number of !important calls. Need to go through these and see if we can refactor them out or if they're necessary (and thus need a stylelint ignore). Once done, enable the declaration-no-important rule.

@nighto
Copy link
Collaborator

nighto commented Dec 18, 2024

Related to that, some form related components (Input, Radio, Select etc.) have !important to override too strict accessibility defaults. Maybe we need to revisit that.

i.e. https://github.com/fortanix/baklava/blob/master/src/components/forms/controls/Radio/Radio.module.scss#L40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants