Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove light-dark() polyfill once we have support #58

Open
mkrause opened this issue Dec 13, 2024 · 0 comments
Open

Remove light-dark() polyfill once we have support #58

mkrause opened this issue Dec 13, 2024 · 0 comments

Comments

@mkrause
Copy link
Collaborator

mkrause commented Dec 13, 2024

See:

// Use minimum targets so that the `light-dark()` polyfill doesn't get applied, which is buggy.

Currently we're relying on the lightningcss polyfill for light-dark(), but it's a bit buggy (doesn't work well with nested color-scheme, and also sometimes doesn't get properly transpiled for some reason, at least in our current build setup).

However, we can't move away at the moment because light-dark() is still relatively new (baseline since 2024-05-13), and in particular Chromatic runs Chrome 121 which doesn't support it. It is expected that Chromatic will upgrade to a newer browser version early 2025, so by that time we should re-evaluate whether we really need this polyfill anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant