fix(payments/generic): EN-392 fixes nil deref if no http resp (#1965)

Author: Quentin-David-24

components/payments/cmd/connectors/internal/connectors/generic/client/errors.go

@@ -7,11 +7,16 @@ import (
 )
 
 var (
-	ErrStatusCodeClientError = errors.New("client error")
-	ErrStatusCodeServerError = errors.New("server error")
+	ErrStatusCodeClientError  = errors.New("client error")
+	ErrStatusCodeServerError  = errors.New("server error")
+	ErrUnreachableServerError = errors.New("unreachable server")
 )
 
 func wrapError(err error, resp *http.Response) error {
+	if resp == nil {
+		return fmt.Errorf("%w: %w", err, ErrUnreachableServerError)
+	}
+
 	statusCode := resp.StatusCode
 
 	if statusCode >= http.StatusBadRequest && statusCode < http.StatusInternalServerError {

components/payments/cmd/connectors/internal/connectors/generic/task_fetch_accounts.go

@@ -72,7 +72,7 @@ func ingestAccounts(
 	for page := 1; ; page++ {
 		accounts, err := c.ListAccounts(ctx, int64(page), pageSize)
 		if err != nil {
-			if errors.Is(err, client.ErrStatusCodeServerError) {
+			if errors.Is(err, client.ErrStatusCodeServerError) || errors.Is(err, client.ErrUnreachableServerError) {
 				return fmt.Errorf("%w: %w", task.ErrRetryable, err)
 			}
 			return err

components/payments/cmd/connectors/internal/connectors/generic/task_fetch_balances.go

@@ -38,7 +38,7 @@ func taskFetchBalances(c *client.Client, config *Config, accountID string) task.
 			// retryable error already handled by the client
 			otel.RecordError(span, err)
 
-			if errors.Is(err, client.ErrStatusCodeServerError) {
+			if errors.Is(err, client.ErrStatusCodeServerError) || errors.Is(err, client.ErrUnreachableServerError) {
 				return fmt.Errorf("%w: %w", task.ErrRetryable, err)
 			}
 

components/payments/cmd/connectors/internal/connectors/generic/task_fetch_beneficiaries.go

@@ -67,7 +67,7 @@ func ingestBeneficiaries(
 	for page := 1; ; page++ {
 		beneficiaries, err := c.ListBeneficiaries(ctx, int64(page), pageSize, state.LastCreatedAt)
 		if err != nil {
-			if errors.Is(err, client.ErrStatusCodeServerError) {
+			if errors.Is(err, client.ErrStatusCodeServerError) || errors.Is(err, client.ErrUnreachableServerError) {
 				return fetchBeneficiariesState{}, fmt.Errorf("%w: %w", task.ErrRetryable, err)
 			}
 

components/payments/cmd/connectors/internal/connectors/generic/task_fetch_transactions.go

@@ -72,7 +72,7 @@ func ingestTransactions(
 	for page := 1; ; page++ {
 		transactions, err := c.ListTransactions(ctx, int64(page), pageSize, state.LastUpdatedAt)
 		if err != nil {
-			if errors.Is(err, client.ErrStatusCodeServerError) {
+			if errors.Is(err, client.ErrStatusCodeServerError) || errors.Is(err, client.ErrUnreachableServerError) {
 				return fetchTransactionsState{}, fmt.Errorf("%w: %w", task.ErrRetryable, err)
 			}