ROASTER-1: Java Statement Fluent Model

[sotty]

Update Copyright

[gastaldi]

The changes in MethodImpl are not updated to the last commit, could you fix that? Thanks.

[sotty]

oops something went wrong with the rebase.. should be fixed now

[gastaldi]

It looks like it is not using the Forge formatter. Could you apply the formatter and rebase with the latest master?

Thanks!

[gastaldi]

This is the formatter used in Eclipse: https://raw.githubusercontent.com/forge/core/master/eclipse-code-formatter-profile.xml

[agoncal]

What about having a method MethodSource<O> setBody( Statement... blocks ); ? This would allow something like :

    method.setBody(
            newDeclare().setVariable(Integer.class, "y"),
            newDeclare().setVariable(String.class, "x")
    );

WDYT ?

[sotty]

Agreed. Actually it's already in the next version of this PR, which I haven't committed yet :)

[agoncal]

Cool. Commit it and I'll give it a try

[gastaldi]

Why is this method needed?

[sotty]

Leftover, removed

On Sat, Jul 25, 2015 at 11:46 PM, George Gastaldi notifications@github.com
wrote:

In api/src/main/java/org/jboss/forge/roaster/model/JavaClass.java
#27 (comment):

@@ -33,4 +34,5 @@
*/
public boolean isLocalClass();

• public JavaClassSource asJavaClassSource();

Why is this method needed?

—
Reply to this email directly or view it on GitHub
https://github.com/forge/roaster/pull/27/files#r35489315.

[sotty]

Next item is checking the consistency of the internal "origin"/"parent" tree

[gastaldi]

Unused import

[gastaldi]

I like this, excellent job!

[gastaldi]

How is parsing of statements work in this proposal? Suppose you want to change some statement in an existing class (change the for loop condition, add another statement), how will this be possible?

[gastaldi]

Can we have more meaningful names for these generics?

[sotty]

Yes, but for uniformity that would need to happen across all the codebase

[sotty]

This is the new feature I (and Mario) started adding in the latest
iteration. It needs more testing and some more work, but see the test case
here:
mpl/src/test/java/org/jboss/forge/test/roaster/model/statements/ModifyMethodBodyTest.java

On Tue, Jul 28, 2015 at 3:21 PM, George Gastaldi notifications@github.com
wrote:

How is parsing of statements work in this proposal? Suppose you want to
change some statement in an existing class (change the for loop condition,
add another statement), how will this be possible?

—
Reply to this email directly or view it on GitHub
#27 (comment).

[sotty]

Oops broken paste :)
https://github.com/sotty/roaster/blob/master/impl/src/test/java/org/jboss/forge/test/roaster/model/statements/ModifyMethodBodyTest.java

On Tue, Jul 28, 2015 at 4:39 PM, Davide Sottara dsotty@gmail.com wrote:

This is the new feature I (and Mario) started adding in the latest
iteration. It needs more testing and some more work, but see the test case
here:

mpl/src/test/java/org/jboss/forge/test/roaster/model/statements/ModifyMethodBodyTest.java

On Tue, Jul 28, 2015 at 3:21 PM, George Gastaldi <notifications@github.com

wrote:

How is parsing of statements work in this proposal? Suppose you want to
change some statement in an existing class (change the for loop condition,
add another statement), how will this be possible?

—
Reply to this email directly or view it on GitHub
#27 (comment).

[jamestyrrell]

Any update on this?

[forge-bot]

Can one of the admins verify this patch?

[gastaldi]

@sotty, are you still working on this PR?

[sotty]

I am, and I have just come back to development this week after a long
period working on other things.
So expect to hear back from me very soon

On Wed, Jul 6, 2016 at 10:16 AM, George Gastaldi notifications@github.com
wrote:

@sotty https://github.com/sotty, are you still working on this PR?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#27 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAf0Olz4-yQGhfH4n_jwRkNDcGFT18uFks5qS8bDgaJpZM4CfcnO
.

[gastaldi]

Awesome, thank you. Haven't fully checked yet, but it would be nice if it supported Lambdas too.

[jamestyrrell]

@sotty That is great to hear as I just started to get my hands dirty and hit a wall when VariableDeclarator.getInit() gives me back a String.

[gastaldi]

Perhaps this project may give some ideas: https://github.com/square/javapoet

[prksean]

@sotty Hi is there any update on this project? Thanks

[kasium]

@sotty I really love this idea. Do you think you are able to finish it in the next time or is there any update on this?

[sotty]

Unfortunately I do not have the bandwidth these days, but I may have time to get back to this project in late around mid May

…

On Sat, Jan 26, 2019 at 10:07 AM Kai Müller ***@***.***> wrote: @sotty <https://github.com/sotty> I really love this idea. Do you think you are able to finish it in the next time or is there any update on this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#27 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAf0OgSmM5Pj4cpJ6dx29rNeh4WjiJHKks5vHH0ngaJpZM4CfcnO> .