Merge pull request #1885 from forcedotcom/release-5.4.0

RELEASE @W-19156628@ Preparing for Release 5.4.0

Author: jfeingold35

.editorconfig

@@ -7,6 +7,10 @@ charset = utf-8
 trim_trailing_whitespace = true
 insert_final_newline = true
 
+[*.ts]
+indent_style = tab
+indent_size = 4
+
 [*.java]
 indent_style = space
 indent_size = 4

.git2gus/config.json

@@ -1,6 +1,6 @@
 {
     "productTag": "a1aB0000000c7jnIAA",
-    "defaultBuild": "[SFCA] Scanner 4.0",
+    "defaultBuild": "[SFCA] Code Analyzer 5.x",
     "hideWorkItemUrl": "true",
     "issueTypeLabels": {
         "type:feature": "USER STORY",
@@ -13,11 +13,11 @@
         "type:duplicate": ""
     },
     "issueEpicMapping": {
-        "USER STORY": "a3QEE000000OpkY2AS",
-        "BUG P0": "a3QEE000000V67Z2AS",
-        "BUG P1": "a3QEE000000V67Z2AS",
-        "BUG P2": "a3QEE000000V67Z2AS",
-        "BUG P3": "a3QEE000000V67Z2AS"
+        "USER STORY": "a3QEE000001n8Ld2AI",
+        "BUG P0": "a3QEE000001n7Sn2AI",
+        "BUG P1": "a3QEE000001n7Sn2AI",
+        "BUG P2": "a3QEE000001n7Sn2AI",
+        "BUG P3": "a3QEE000001n7Sn2AI"
     },
     "gusTitlePrefix": "[GitHub Issue]",
     "statusWhenClosed": "FIXED"

.github/ISSUE_TEMPLATE/0-code_analyzer_bug.yml

@@ -27,7 +27,8 @@ body:
       label: Output / Logs
       description: Attach any output or logs here.
       placeholder: |
-        Add log output or drag files here.
+        Add log output here. This will be automatically formatted into code, so no need for backticks.
+      render: shell
   - type: textarea
     attributes:
       label: Steps To Reproduce

.github/ISSUE_TEMPLATE/1-scanner_bug.yml

@@ -28,7 +28,8 @@ body:
       label: Output / Logs
       description: Attach any output or logs here.
       placeholder: |
-        Add log output or drag files here.
+        Add log output here. This will be automatically formatted into code, so no need for backticks.
+      render: shell
   - type: textarea
     attributes:
       label: Steps To Reproduce
@@ -65,22 +66,20 @@ body:
       required: true
   - type: input
     attributes:
-      label: Salesforce CLI Version
+      label: Extension Version
       description: |
-        What do you get when you run the "sf --version" command in the terminal?
+        What version do you see for the Salesforce Code Analyzer VS Code Extension?
       placeholder: |
-        Example: @salesforce/cli/2.90.4 darwin-x64 node-v22.15.0
+        Example: Version: 1.9.0
     validations:
       required: true
-  - type: dropdown
+  - type: input
     attributes:
-      label: Using v4
-      description: "Are you using Code Analyzer v4? (Is the setting 'Code Analyzer: Use v4 (Deprecated)' checked?)"
-      options:
-        - ""
-        - "No"
-        - "Yes"
-        - "Not sure"
+      label: Salesforce CLI Version
+      description: |
+        What do you get when you run the "sf --version" command in the terminal?
+      placeholder: |
+        Example: @salesforce/cli/2.90.4 darwin-x64 node-v22.15.0
     validations:
       required: true
   - type: input
@@ -89,7 +88,7 @@ body:
       description: |
         What do you get when you run the "sf plugins" command in the terminal?
       placeholder: |
-        code-analyzer 5.0.0; or if using v4: @salesforce/sfdx-scanner 4.12.0
+        code-analyzer 5.0.0
     validations:
       required: false
   - type: input

.github/ISSUE_TEMPLATE/2-vscode_extension_bug.yml

@@ -4,14 +4,6 @@ on:
     types: [edited, opened, reopened, synchronize]
 
 jobs:
-  # Prevent merging to dev-4 or main-4 to preserve until we're ready to delete
-  verify_target_branch:
-    runs-on: ubuntu-latest
-    steps:
-      - if: ${{ github.base_ref == 'dev-4' || github.base_ref == 'main-4' }}
-        run: |
-          echo "Forbidden to merge this branch into dev-4 or main-4"
-          exit 1
   # We need to verify that the Pull Request's title matches the desired format.
   verify_pr_title:
     runs-on: ubuntu-latest

.github/workflows/validate-pr.yml

@@ -124,10 +124,15 @@ If you specify neither `--view` nor `--output-file`, then the default table view
 
 # flags.output-file.summary
 
-Name of the file where the selected rules are written. The file format depends on the extension you specify; currently, only .json is supported for JSON-formatted output.
+Name of the file where the selected rules are written. The file format depends on the extension you specify; the currently supported extensions are .json and .csv
 
 # flags.output-file.description
 
-If you specify a file within folder, such as `--output-file ./out/rules.json`, the folder must already exist, or you get an error. If the file already exists, it's overwritten without prompting.
+If you don't specify this flag, the command outputs the rules to only the terminal. Use this flag to write the rules to a file; the format of the rules depends on the extension you provide. For example, `--output-file rules.csv` creates a comma-separated values file. You can specify one of these extensions:
+
+- .csv
+- .json
 
-If you don't specify this flag, the command outputs the rules to only the terminal. 
+To output the rules to multiple files, specify this flag multiple times. For example, `--output-file rules.json --output-file rules.csv` creates both a JSON file and a CSV file.
+
+If you specify a file within folder, such as `--output-file ./out/rules.json`, the folder must already exist, or you get an error. If the file already exists, it's overwritten without prompting.

messages/rules-command.md

@@ -1,3 +1,3 @@
 # error.unrecognized-file-format
 
-The output file %s has an unsupported extension. Valid extension(s): .json.
+The output file %s has an unsupported extension. Valid extension(s): .json, .csv