UIREQMED-65: Minor improvements and code fixes

Author: Dmitriy-Litvinenko

CHANGELOG.md

@@ -1,5 +1,8 @@
 # Change history for ui-requests-mediated
 
+## 2.1.0 (IN PROGRESS)
+* Minor improvements and code fixes. Refs UIREQMED-65.
+
 ## [2.0.0] (https://github.com/folio-org/ui-requests-mediated/tree/v2.0.0) (2024-11-30)
 [Full Changelog](https://github.com/folio-org/ui-requests-mediated/compare/v1.1.0...v2.0.0)
 * Print slip for Mediated requests activity - Send item in transit. Refs UIREQMED-40.

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@folio/requests-mediated",
-  "version": "2.0.0",
+  "version": "2.1.0",
   "description": "Mediated requests",
   "main": "src/index.js",
   "repository": "folio-org/ui-requests-mediated",
@@ -77,7 +77,8 @@
       "requests-mediated": "2.0",
       "requests-mediated-actions": "1.0",
       "request-preference-storage": "2.0",
-      "circulation": "14.2"
+      "circulation": "14.4",
+      "users": "16.3"
     },
     "permissionSets": [
       {

src/components/ConfirmItem/ConfirmItem.js

@@ -28,7 +28,7 @@ import {
 const ConfirmItem = ({
   pristine,
   paneTitle,
-  navigationMenuFunction,
+  navigationMenuUrl,
   confirmItemType,
   contentData,
   handleSubmit,
@@ -52,7 +52,7 @@ const ConfirmItem = ({
         defaultWidth={FILTER_PANE_WIDTH}
         paneTitle={paneTitle}
       >
-        <NavigationMenu value={navigationMenuFunction} />
+        <NavigationMenu value={navigationMenuUrl} />
       </Pane>
       <Pane
         data-testid="confirmItemPane"
@@ -101,7 +101,7 @@ const ConfirmItem = ({
 ConfirmItem.propTypes = {
   pristine: PropTypes.bool,
   paneTitle: PropTypes.node.isRequired,
-  navigationMenuFunction: PropTypes.func.isRequired,
+  navigationMenuUrl: PropTypes.string.isRequired,
   confirmItemType: PropTypes.oneOf([CONFIRM_ITEM_TYPES.CONFIRM_ITEM_ARRIVAL, CONFIRM_ITEM_TYPES.SEND_ITEM_IN_TRANSIT]).isRequired,
   contentData: PropTypes.arrayOf(PropTypes.object),
   handleSubmit: PropTypes.func.isRequired,

src/components/ConfirmItem/ConfirmItem.test.js

@@ -35,7 +35,7 @@ const labelIds = {
 const basicProps = {
   pristine: false,
   paneTitle: 'paneTitle',
-  navigationMenuFunction: jest.fn(),
+  navigationMenuUrl: 'confirmItem',
   confirmItemType: CONFIRM_ITEM_TYPES.CONFIRM_ITEM_ARRIVAL,
   contentData: [],
   handleSubmit: jest.fn(),
@@ -72,7 +72,7 @@ describe('ConfirmItem', () => {
 
   it('should render navigation menu with correct props', () => {
     expect(NavigationMenu).toHaveBeenCalledWith(expect.objectContaining({
-      value: basicProps.navigationMenuFunction,
+      value: basicProps.navigationMenuUrl,
     }), {});
   });
 

src/components/ConfirmItem/components/ConfirmItemList.js

@@ -109,7 +109,6 @@ const ConfirmItem = ({
 }) => {
   return (
     <MultiColumnList
-      id="confirmItemList"
       fullWidth
       visibleColumns={CONFIRM_ITEM_COLUMNS_NAME}
       columnWidths={COLUMN_WIDTHS}

src/components/ConfirmItemArrival/ConfirmItemArrival.js

@@ -44,7 +44,7 @@ const ConfirmItemArrival = () => {
     <>
       <ConfirmItem
         paneTitle={intl.formatMessage({ id: 'ui-requests-mediated.confirmItemArrival.paneTitle' })}
-        navigationMenuFunction={getConfirmItemArrivalUrl()}
+        navigationMenuUrl={getConfirmItemArrivalUrl()}
         confirmItemType={CONFIRM_ITEM_TYPES.CONFIRM_ITEM_ARRIVAL}
         contentData={confirmItemArrivalData}
         onSubmit={handleSubmit}

src/components/ConfirmItemArrival/ConfirmItemArrival.test.js

@@ -28,7 +28,7 @@ describe('ConfirmItemArrival', () => {
   it('should render ConfirmItem with correct props', () => {
     expect(ConfirmItem).toHaveBeenCalledWith(expect.objectContaining({
       paneTitle: messageIds.paneTitle,
-      navigationMenuFunction: getConfirmItemArrivalUrl(),
+      navigationMenuUrl: getConfirmItemArrivalUrl(),
       confirmItemType: CONFIRM_ITEM_TYPES.CONFIRM_ITEM_ARRIVAL,
       contentData: [],
       onSubmit: expect.any(Function),

src/components/MediatedRequestsActivities/components/MediatedRequestsFilters/MediatedRequestsFilters.js

@@ -63,7 +63,7 @@ MediatedRequestsFilters.propTypes = {
     ...MEDIATED_REQUEST_LEVEL_PROP_TYPES,
   }).isRequired,
   searchValue: PropTypes.shape({
-    query: PropTypes.string.isRequired,
+    query: PropTypes.string,
   }).isRequired,
   getSearchHandlers: PropTypes.func.isRequired,
   resetAll: PropTypes.func.isRequired,

src/components/MediatedRequestsActivities/components/MediatedRequestsFilters/components/Search/Search.js

@@ -4,6 +4,7 @@ import {
 import PropTypes from 'prop-types';
 import {
   FormattedMessage,
+  useIntl,
 } from 'react-intl';
 import {
   isEmpty,
@@ -30,6 +31,7 @@ const Search = ({
   resetAll,
   activeFilters,
 }) => {
+  const intl = useIntl();
   const handleChange = useCallback((e) => {
     if (e.target.value) {
       getSearchHandlers().query(e);
@@ -47,6 +49,7 @@ const Search = ({
       className={styles.searchFieldContainer}
     >
       <SearchField
+        aria-label={intl.formatMessage({ id: 'stripes-smart-components.search' })}
         data-testid="mediatedRequestsActivitiesSearch"
         autoFocus
         autoComplete="off"
@@ -88,7 +91,7 @@ Search.propTypes = {
     ...MEDIATED_REQUEST_LEVEL_PROP_TYPES,
   }).isRequired,
   searchValue: PropTypes.shape({
-    query: PropTypes.string.isRequired,
+    query: PropTypes.string,
   }).isRequired,
   getSearchHandlers: PropTypes.func.isRequired,
   resetAll: PropTypes.func.isRequired,

src/components/MediatedRequestsActivities/components/MediatedRequestsList/MediatedRequestsList.js

@@ -142,7 +142,7 @@ const MediatedRequestsList = ({
 };
 
 MediatedRequestsList.propTypes = {
-  visibleColumns: PropTypes.object,
+  visibleColumns: PropTypes.arrayOf(PropTypes.string).isRequired,
   contentData: PropTypes.arrayOf(PropTypes.object).isRequired,
   source: PropTypes.shape({
     totalCount: PropTypes.func,