UICAL-285 - Disable 'Actions' menu on DCB Calendar. #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncovercash
approved these changes
Sep 28, 2024
src/views/panes/InfoPane.test.tsx
Outdated
| // await userEvent.click(screen.getByRole('button', { name: 'Actions' })); | ||
| // }); | ||
|
|
||
| // expect(screen.getByRole('button', { name: 'Edit' })).toBeInTheDocument(); |
There was a problem hiding this comment.
Why are these commented out?
There was a problem hiding this comment.
Removed the commented code as it is unnecessary
|
BE had not implemented the change at api level for DCB calendar to not be editable. They might do it for ramsons but not for Q csp5 |
manvendra-s-rathore
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
UICAL-285 - Disable editing of DCB calendar
@folio-org/fe-tl-reviewers @ncovercash Kindly review this PR with priority as it is needed for Q CSP#5.
Approach
DCB transactions are associated with an umbrella calendar hardcoded in BE as "DCB Calendar".
The actions menu for this DCB Calendar is supposed to be hidden i.e., editing DCB Calendar is forbidden from UI.
Refs
https://folio-org.atlassian.net/browse/UICAL-285
Screenshots
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally, all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of inter-module and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.