Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UICAL-282: Implement ordering for exception groups and individual exceptions #528

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

chris-hellen
Copy link
Contributor

Purpose

To make the displaying of exceptions more clear and user friendly.

Approach

Sorts both exception groups and individual exceptions by start date.

Refs

UICAL-282

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added an appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

@chris-hellen chris-hellen requested a review from ncovercash June 13, 2024 15:32
Copy link

github-actions bot commented Jun 13, 2024

Jest Unit Test Statistics

    1 files  ±0    73 suites  ±0   1m 17s ⏱️ -1s
331 tests ±0  330 ✔️ ±0  1 💤 ±0  0 ±0 
358 runs  ±0  357 ✔️ ±0  1 💤 ±0  0 ±0 

Results for commit 1547df8. ± Comparison against base commit 6290e2d.

♻️ This comment has been updated with latest results.

Copy link

@chris-hellen chris-hellen merged commit b0031e2 into master Jun 13, 2024
5 checks passed
@chris-hellen chris-hellen deleted the UICAL-282 branch June 13, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants