Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STRIPES-868 BREAKING bump react-intl to v6 #494

Merged
merged 3 commits into from
Sep 22, 2023
Merged

STRIPES-868 BREAKING bump react-intl to v6 #494

merged 3 commits into from
Sep 22, 2023

Conversation

zburke
Copy link
Member

@zburke zburke commented Sep 11, 2023

Refs UICAL-275

@github-actions
Copy link

github-actions bot commented Sep 11, 2023 •
edited
Loading

Jest Unit Test Statistics

    1 files  ±0    71 suites  ±0   5m 9s ⏱️ + 1m 44s
331 tests ±0  330 ✔️ ±0  1 💤 ±0  0 ❌ ±0 
358 runs  ±0  357 ✔️ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 174d15c. ± Comparison against base commit 8b38be8.

♻️ This comment has been updated with latest results.

@ncovercash
Copy link
Member

image
a bit dramatic BREAKING, lol

@ncovercash ncovercash requested review from nhanaa, danetsao, ncovercash and a team September 11, 2023 21:31
ncovercash
ncovercash requested changes Sep 11, 2023
View reviewed changes
Copy link
Member

@ncovercash ncovercash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump the package.json version too?

@zburke
Copy link
Member Author

zburke commented Sep 12, 2023

@ncovercash , I bumped the package version, but this PR will fail until somebody addresses UICAL-271. That ticket wasn't meant to be a bug, but it sort of became one due to the @rehooks/local-storage patch release that same week that introduced rehooks/local-storage/issues/103.

It's true the formatjs changelog is a little dramatic, but I love them for actually following the semver rules.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zburke zburke merged commit ede0fcf into master Sep 22, 2023
4 checks passed
@zburke zburke deleted the STRIPES-868 branch September 22, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danetsao danetsao danetsao approved these changes

@ncovercash ncovercash ncovercash approved these changes

@nhanaa nhanaa Awaiting requested review from nhanaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zburke @ncovercash @danetsao