fix(authority-prefix): delete sequence during deletion of authority-source-file (#253)

fix(authority-prefix): delete sequence during deletion of authority-source-file.

Previously, during creation of the authority-source-file with the same prefix as previously deleted authority-source-file, program generated an error that states when you try to recreate a sequence with the same name after deleting the associated row, it encounters a conflict because it thinks the sequence already exists. This commit solves this error by deleting sequence linked to authority-source-file during its deletion.

- add deleteSequence method
- refactor deleteAuthoritySourceFile_positive_deleteExistingEntity test
- refactor shouldDeleteAuthoritySourceFileById test

Closes MODELINKS-211

Author: GeloPakDev1

NEWS.md

@@ -22,7 +22,6 @@
 * Make system user usage optional ([MODELINKS-150](https://issues.folio.org/browse/MODELINKS-150) and [MODROLESKC-24](https://issues.folio.org/browse/MODROLESKC-24))
 * Propagate authority archives deletion to member tenants ([MODELINKS-195](https://issues.folio.org/browse/MODELINKS-195))
 * Implement endpoint for bulk authorities upsert from external file ([MODELINKS-173](https://issues.folio.org/browse/MODELINKS-173))
-* Create custom Mockito verifies for Hibernate entities ([MODELINKS-209](https://issues.folio.org/browse/MODELINKS-209))
 * Add possibility to filter Authority records by (un)defined fields in Cql query ([MODELINKS-214](https://issues.folio.org/browse/MODELINKS-214))
 
 ### Bug fixes
@@ -32,9 +31,10 @@
 * Remove foreign key for authority_data_stat ([MODELINKS-155](https://issues.folio.org/browse/MODELINKS-155))
 * Fix empty links list propagation ([MODELINKS-166](https://issues.folio.org/browse/MODELINKS-166))
 * Fix base url of authority file after linking ([MODELINKS-192](https://folio-org.atlassian.net/browse/MODELINKS-192))
+* Fix authority source file sequence deletion ([MODELINKS-211](https://issues.folio.org/browse/MODELINKS-211))
 
 ### Tech Dept
-* Description ([ISSUE_NUMBER](https://issues.folio.org/browse/ISSUE_NUMBER))
+* Create custom Mockito verifies for Hibernate entities ([MODELINKS-209](https://issues.folio.org/browse/MODELINKS-209))
 
 ### Dependencies
 * Bump `folio-spring-support` from `7.2.0` to `7.2.1`

src/main/java/org/folio/entlinks/controller/delegate/AuthoritySourceFileServiceDelegate.java

@@ -83,6 +83,9 @@ public void deleteAuthoritySourceFileById(UUID id) {
     var entity = service.getById(id);
     validateActionRightsForTenant(DomainEventType.DELETE);
 
+    if (entity.getSequenceName() != null) {
+      service.deleteSequence(entity.getSequenceName());
+    }
     service.deleteById(id);
     propagationService.propagate(entity, DELETE, context.getTenantId());
   }

src/main/java/org/folio/entlinks/service/authority/AuthoritySourceFileService.java

@@ -158,6 +158,14 @@ public void createSequence(String sequenceName, int startNumber) {
     jdbcTemplate.execute(command);
   }
 
+  public void deleteSequence(String sequenceName) {
+    var command = String.format("""
+        DROP SEQUENCE IF EXISTS %s.%s;
+        """,
+        moduleMetadata.getDBSchemaName(folioExecutionContext.getTenantId()), sequenceName);
+    jdbcTemplate.execute(command);
+  }
+
   public String nextHrid(UUID id) {
     log.debug("nextHrid:: Attempting to get next AuthoritySourceFile HRID [id: {}]", id);
     var sourceFile = getById(id);

src/test/java/org/folio/entlinks/controller/AuthoritySourceFilesControllerIT.java

@@ -407,15 +407,22 @@ void updateWithOldVersion_negative_shouldReturnOptimisticLockingError() throws E
   @Test
   @DisplayName("DELETE: Should delete existing authority source file")
   void deleteAuthoritySourceFile_positive_deleteExistingEntity() {
-    var sourceFile = prepareAuthoritySourceFile(0);
-    sourceFile.setSequenceName(String.format("hrid_authority_local_file_%s_seq", SOURCE_FILE_CODE_IDS[0]));
-    createAuthoritySourceFile(sourceFile);
+    var id = UUID.randomUUID();
+    var code = "abc";
+    var startNumber = 1;
+    var dto = new AuthoritySourceFilePostDto()
+        .id(id)
+        .name("name")
+        .code(code)
+        .hridManagement(new AuthoritySourceFilePostDtoHridManagement().startNumber(startNumber));
 
-    doDelete(authoritySourceFilesEndpoint(sourceFile.getId()));
+    doPost(authoritySourceFilesEndpoint(), dto);
+    doDelete(authoritySourceFilesEndpoint(id));
 
     assertEquals(0, databaseHelper.countRows(DatabaseHelper.AUTHORITY_SOURCE_FILE_TABLE, TENANT_ID));
     assertEquals(0, databaseHelper.countRows(DatabaseHelper.AUTHORITY_SOURCE_FILE_CODE_TABLE, TENANT_ID));
-    assertNull(databaseHelper.queryAuthoritySourceFileSequenceStartNumber(sourceFile.getSequenceName()));
+    var sequenceName = String.format("hrid_authority_local_file_%s_seq", code);
+    assertNull(databaseHelper.queryAuthoritySourceFileSequenceStartNumber(sequenceName));
   }
 
   @Test

src/test/java/org/folio/entlinks/controller/delegate/AuthoritySourceFileServiceDelegateTest.java

@@ -246,6 +246,7 @@ void shouldDeleteAuthoritySourceFileById() {
 
     delegate.deleteAuthoritySourceFileById(existing.getId());
 
+    verify(service).deleteSequence(existing.getSequenceName());
     verify(service).deleteById(existing.getId());
     verify(propagationService).propagate(existing, DELETE, TENANT_ID);
   }