Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tns:MovingCondition in tns:IslamicHoliday #284

Closed
XSpielinbox opened this issue Aug 28, 2023 · 2 comments · Fixed by #324
Closed

Add support for tns:MovingCondition in tns:IslamicHoliday #284

XSpielinbox opened this issue Aug 28, 2023 · 2 comments · Fixed by #324
Labels
status: new Initial state for every issue / pull request type: enhancement A general enhancement
Milestone

Comments

@XSpielinbox
Copy link
Contributor

XSpielinbox commented Aug 28, 2023

More information

Please enable to define child-elements of type tns:MovingCondition for elements of type tns:IslamicHoliday, as is possible with elements of type fixed.

This would make definition for e.g. the Hari Raya Haji and Hari Raya Puasa public holidays in Singapore (moved to the following Monday, if it would fall on a Sunday) way easier.

So, something like the following should be valid, what it is not at the moment:

<tns:IslamicHoliday type="ID_UL_ADHA_2" validFrom="2023" descriptionPropertiesKey="HARI_RAYA_HAJI">
    <tns:MovingCondition substitute="SUNDAY" with="NEXT" weekday="MONDAY"/>
</tns:IslamicHoliday>

see also https://www.mom.gov.sg/newsroom/press-replies/2008/rules-on-off-in-lieu

Currently when a public holiday falls on a Sunday, the following Monday will be, by law, a holiday.

@XSpielinbox XSpielinbox added the status: new Initial state for every issue / pull request label Aug 28, 2023
@derTobsch derTobsch added the type: enhancement A general enhancement label Sep 6, 2023
@derTobsch
Copy link
Contributor

see #283

@XSpielinbox
Copy link
Contributor Author

Thank you!
I will update the Singapore holiday definitions accordingly as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: new Initial state for every issue / pull request type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants