Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support text posts and video #8

Open
chris-y opened this issue Jun 15, 2024 · 6 comments
Open

Support text posts and video #8

chris-y opened this issue Jun 15, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request on hold

Comments

@chris-y
Copy link
Contributor

chris-y commented Jun 15, 2024

Doesn't support text posts - needs a URL and assumes it's a picture.

Don't know if there is any way to tell if a URL isn't an image (from the Lemmy API)

@chris-y chris-y self-assigned this Jun 18, 2024
@chris-y chris-y added the enhancement New feature or request label Jun 18, 2024
@chris-y
Copy link
Contributor Author

chris-y commented Jun 24, 2024

I did add a feature to force only images to be included. This is a precursor to allowing other content types as they need to be handled differently to images, and some of our communities need the non-image posts filtered out as we want to showcase images, not accidentally get a META post featured.

@chris-y
Copy link
Contributor Author

chris-y commented Jun 29, 2024

This needs to be the next thing I work on.

I think we have four main types of posts;

  • Images
    • Images
      These are already handled
  • Text
  • URL
    • Posts with a link to another site/article
      We could post a summary of the body, but sometimes there's nothing. Maybe summarise the website (if we can figure a sensible way of doing this - experimenting with tldrthis and smmry)
  • Video
    • Posts with a video or link to a video
      Ideally we need to post a thumbnail?

@M4rtineski
Copy link
Contributor

@chris-y Do NOT include the body or if you want to make it a setting to disable it for specific communities. Dad jokes for example has punchlines in the body and that would spoiler it.

chris-y added a commit that referenced this issue Jun 29, 2024
chris-y added a commit that referenced this issue Jun 30, 2024
Posts a summary of the text
We may need to exclude this for certain communities - see #8
@chris-y
Copy link
Contributor Author

chris-y commented Jun 30, 2024

Opened #36 which we might need for videos.

@chris-y chris-y mentioned this issue Jun 30, 2024
40 tasks
chris-y added a commit that referenced this issue Jun 30, 2024
@chris-y
Copy link
Contributor Author

chris-y commented Jul 2, 2024

Need to check what we get as URL for the top post when it doesn't contain an image.

@chris-y chris-y added the on hold label Jul 5, 2024
@chris-y
Copy link
Contributor Author

chris-y commented Jul 5, 2024

I think this is done bar allowing the description to be disabled. That will wait until we have a community which requires it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request on hold
Projects
None yet
Development

No branches or pull requests

2 participants