You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the work on this gem, it has been quite useful in different projects through the years 😅
While doing some tests found a small issue doing Recurrence.default_starts_date, which raises an exception. But if you do Recurrence_.default_starts_date everything works fine. We can also just force the starts option, and everything is fine.
Notice that you've changed default_stars_date class method a couple months ago, which raised this issue when using Recurrence or any class that extends from Recurrence_
Is there any specific reason to have the method like:
Hi,
Thanks for the work on this gem, it has been quite useful in different projects through the years 😅
While doing some tests found a small issue doing
Recurrence.default_starts_date
, which raises an exception. But if you doRecurrence_.default_starts_date
everything works fine. We can also just force thestarts
option, and everything is fine.Notice that you've changed
default_stars_date
class method a couple months ago, which raised this issue when usingRecurrence
or any class that extends fromRecurrence_
Is there any specific reason to have the method like:
Instead of directly use the constant:
If you don't see any issue with the above suggestion, I would be glad to open the PR to fix it.
Edit:
While running the test got the intention for it 👍
So could it be something like this?
Also, this didn't appear on the tests cause in the
test_helper.rb#setup
is setting itThe text was updated successfully, but these errors were encountered: