Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some refactoring in formula types #248

Open
jvoigtlaender opened this issue Jan 23, 2025 · 0 comments · May be fixed by #251
Open

Some refactoring in formula types #248

jvoigtlaender opened this issue Jan 23, 2025 · 0 comments · May be fixed by #251

Comments

@jvoigtlaender
Copy link
Member

Wouldn't this:

data Literal
= Literal { letter :: Char} -- ^ positive sign
| Not { letter :: Char} -- ^ negative sign
better be given constructors as follows?

data Literal
    = Pos { letter :: Char} -- ^ positive sign
    | Neg { letter :: Char} -- ^ negative sign

Also, instead of

class Formula a where
literals :: a -> [Literal]
atomics :: a -> [Literal]
have the following?

class Formula a where
    literals :: a -> [Literal]
    atomics :: a -> [Char]
@nimec01 nimec01 linked a pull request Jan 31, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant