-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not all rules support visibility #107
Comments
seems like this case is actually more complicated, if i make it support visibility it fails with an args issue:
and it's also no longer runnable:
|
I don't see a clear solution to the visibility issues as it isn't possible to know whether a given rule or macro supports Regarding |
I drafted #108 based on your example and can't reproduce the The remaining problems:
|
when I just added |
Thanks, I sent #110 to fix this part. |
It seems like with_cfg assumes that all macros passed supports kwargs / manually visibility, but I found a case that doesn't with rules_uv:
https://github.com/theoremlp/rules_uv/blob/ce66cb575dd67072f8de70d02c46131bad55b994/uv/private/pip.bzl#L111-L119
The text was updated successfully, but these errors were encountered: