Skip to content

Commit dc4b3e4

Browse files
alexeaglefmeum
authored andcommitted
chore: update default branch of rules_nodejs (bazelbuild#1581)
I'm not sure why these are hardcoded here, when GitHub API provides a way to know the name of the default branch in a repo. rules_nodejs is preparing a 6.0 which is big breaking change, so we're also taking the opportunity to switch to the standard name for default branch. NOTE: I've left the `stable` branch on the repo, but it still points to the old 5.x branch of code, so this change is needed to start testing the current version.
1 parent 5594f2f commit dc4b3e4

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

buildkite/bazelci.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@
372372
},
373373
"rules_nodejs": {
374374
"git_repository": "https://github.com/bazelbuild/rules_nodejs.git",
375-
"http_config": "https://raw.githubusercontent.com/bazelbuild/rules_nodejs/stable/.bazelci/presubmit.yml",
375+
"http_config": "https://raw.githubusercontent.com/bazelbuild/rules_nodejs/main/.bazelci/presubmit.yml",
376376
"pipeline_slug": "rules-nodejs-nodejs",
377377
},
378378
"rules_perl": {

buildkite/terraform/bazel-testing/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ resource "buildkite_pipeline" "rules-nodejs-nodejs" {
152152
name = "rules_nodejs :nodejs:"
153153
repository = "https://github.com/bazelbuild/rules_nodejs.git"
154154
steps = templatefile("pipeline.yml.tpl", { envs = {}, steps = { commands = ["curl -sS \"https://raw.githubusercontent.com/bazelbuild/continuous-integration/testing/buildkite/bazelci.py?$(date +%s)\" -o bazelci.py", "python3.6 bazelci.py project_pipeline --monitor_flaky_tests=true | tee /dev/tty | buildkite-agent pipeline upload"] } })
155-
default_branch = "stable"
155+
default_branch = "main"
156156
}
157157

158158
resource "buildkite_pipeline" "publish-bazel-binaries" {

buildkite/terraform/bazel/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1748,7 +1748,7 @@ resource "buildkite_pipeline" "rules-nodejs-nodejs" {
17481748
name = "rules_nodejs :nodejs:"
17491749
repository = "https://github.com/bazelbuild/rules_nodejs.git"
17501750
steps = templatefile("pipeline.yml.tpl", { envs = {}, steps = { commands = ["curl -sS \"https://raw.githubusercontent.com/bazelbuild/continuous-integration/master/buildkite/bazelci.py?$(date +%s)\" -o bazelci.py", "python3.6 bazelci.py project_pipeline | tee /dev/tty | buildkite-agent pipeline upload"] } })
1751-
default_branch = "stable"
1751+
default_branch = "main"
17521752
team = [{ access_level = "BUILD_AND_READ", slug = "bazel" }, { access_level = "BUILD_AND_READ", slug = "rules-nodejs" }]
17531753
provider_settings {
17541754
trigger_mode = "code"

0 commit comments

Comments
 (0)