Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process for creating group room and allowing others to join unclear. #113

Open
RobBrooks opened this issue May 24, 2023 · 2 comments
Open
Labels

Comments

@RobBrooks
Copy link

Hi,

I can't seem to find an example of group rooms.

I don't really understand the reason for supplying a list of users when you create it, so I just start with an empty list and this allows creation of the room with the user who created it able to type messages which get saved.

If I have another user who wishes to join the discussion, how does that work?
I have the id for the room which was created but I feel there really should be a joinRoom(roomId, user) function which adds the current firebase user to the room but obviously there isn't one.

Many thanks.

@demchenkoalex
Copy link
Member

Hello.

I feel like this package makes people to wonder more why is it done in some way and why feature X is not here, rather than actually help with something.

Actual lib code is like 1-2 days of work, it just uses Firebase libs underneath, nothing fancy. Adding a join room is not a problem even outside of the lib. I think I need to convert this to just an example app, and let people do things like they need for the specific project.

I am currently focused on re-writing the UI properly from scratch so I wouldn't expect any activity here, so I'd suggest to just write this yourself using Firebase and then you can design your code in a way that suits your needs, rather than relying on something that is obviously doesn't work and only stands in way.

@RobBrooks
Copy link
Author

I think you've done really well here and the work already undertaken ( and in particular the presentation of the website ) is such that it creates a sense of completeness, even if by your own admission, it isn't.
Please do not misunderstand, there are no complaints here - just gratitude.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants