Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of a context to all *Builders #608

Open
vasilich6107 opened this issue Jun 10, 2024 · 4 comments
Open

Add support of a context to all *Builders #608

vasilich6107 opened this issue Jun 10, 2024 · 4 comments
Labels
feature New feature or request

Comments

@vasilich6107
Copy link

vasilich6107 commented Jun 10, 2024

Is your feature request related to a problem?

Flutter canonical implemetation of a builder patter includes passing a context through

What solution would you suggest?

add build context param

Is there any additional solution to that?

no

@vasilich6107 vasilich6107 added the feature New feature or request label Jun 10, 2024
@demchenkoalex
Copy link
Member

Flutter canonical implementation of a builder pattern

Thanks for letting me know! The code in this repository is not canonical in any way, cause when I wrote it I used react native/ios patterns, since it was the only thing I knew. I will make sure to follow more best practices on a v2 branch!

@vasilich6107
Copy link
Author

sure, I can do a PR if it works for you

@demchenkoalex
Copy link
Member

if it is a non breaking one, you can :)

@vasilich6107
Copy link
Author

@demchenkoalex it's definetely breaking and probably suitable for v2 cause all *Builder methods will receive additional parameter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants