Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Deleting fly_app deletes everything, other resources left in state but can't delete #163

Open
OJFord opened this issue Mar 8, 2023 · 0 comments

Comments

@OJFord
Copy link
Contributor

OJFord commented Mar 8, 2023

Say you change the name of a fly_app, which forces a replacement of the IP, machine, everything - they'll race to delete and anything the fly_app beats won't be able to delete, as it will now get a 404. (Without checking, I assume the API is something like /apps/:id/machines/:id).

If it already doesn't exist (either app or machine), delete should just succeed, remove from state. There's no need to alert that the app doesn't exist, it must be correct, since it was checked on create/import when we added it to the state.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant