.services: was null, but now ...

[andrewbaxter]

I encountered this error after updating a machine image:

│ When applying changes to fly_machine.MYID, provider "provider[\"registry.terraform.io/fly-apps/fly\"]" produced an unexpected new value: .services: was null, but now
│ cty.ListValEmpty(cty.Object(map[string]cty.Type{"internal_port":cty.Number, "ports":cty.List(cty.Object(map[string]cty.Type{"handlers":cty.List(cty.String), "port":cty.Number})),
│ "protocol":cty.String})).

I guess Read and Create set services = nil but this is missing from Update? At

	tfservices := ServicesToTfServices(updatedMachine.Config.Services)

[andrewbaxter]

Yeah,

diff --git a/internal/provider/machine_resource.go b/internal/provider/machine_resource.go
index 83b4dd9..e46b78a 100644
--- a/internal/provider/machine_resource.go
+++ b/internal/provider/machine_resource.go
@@ -4,6 +4,7 @@ import (
        "context"
        "errors"
        "fmt"
+
        "github.com/fly-apps/terraform-provider-fly/internal/utils"
        "github.com/fly-apps/terraform-provider-fly/pkg/apiv1"
        "github.com/hashicorp/terraform-plugin-framework/diag"
@@ -552,6 +553,10 @@ func (mr flyMachineResource) Update(ctx context.Context, req resource.UpdateRequ
 
        tfservices := ServicesToTfServices(updatedMachine.Config.Services)
 
+       if plan.Services == nil && len(tfservices) == 0 {
+               tfservices = nil
+       }
+
        state = flyMachineResourceData{
                Name:       types.String{Value: updatedMachine.Name},
                Region:     types.String{Value: updatedMachine.Region},

seems to have fixed it.

[andrewbaxter]

This prevents updating machines with no services defined (eg: databases).

[loganmimaroglu]

I ran into a similar issue. As a temporary fix, I initially defined the service on my database machine to be an empty array, that way I am able to update the configuration on subsequent deployments:

resource "fly_machine" "database" {
  ...
  services  = []
  ...
}

[kdevan]

Same on my end. If you omit services completely, tfstate still sets services = [] but it expects null. If I manually change tfstate to services = null it gets rid of the error and I'm able to continue forward until the next update. But @GlueStix workaround is much better :)