Migrate ios_books SceneDelegate for UIScene#2845
Open
Wreos wants to merge 1 commit into
Open
Conversation
Author
|
Changelog link in checklist opens 404, since there is no root CHANGELOG.md. Should i create one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#176957
Migrated SceneDelegate.swift to use UI scene using this guideline https://docs.flutter.dev/release/breaking-changes/uiscenedelegate#migration-guide-for-flutter-apps for ios_books app
While testing this sample locally, I noticed a separate existing issue in
IosBooks/ViewController.swift: the Google Books response is force-unwrapped. The unauthenticated request currently returns HTTP 429/quota errors in some environments, sojson["items"] as! [[String: Any]]can crash at runtime.I kept this PR scoped to the UIScene migration only, but I can file or send a separate follow-up to make the sample parse the API response defensively, WDYT?
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.