Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

https://gallery.flutter.dev/#/demo/text-field is very verbose #874

Open
kamlesh1808 opened this issue Jun 22, 2022 · 3 comments
Open

https://gallery.flutter.dev/#/demo/text-field is very verbose #874

kamlesh1808 opened this issue Jun 22, 2022 · 3 comments
Labels
enhancement New feature or request P3 Priority 3 - Could have

Comments

@kamlesh1808
Copy link

Use case

I have reviewed example code https://gallery.flutter.dev/#/demo/text-field. I think it is very verbose.
The concept of having TextFormFieldDemo and TextFormFieldDemoState I believe is a lot of code for such simple demo app.

Proposal

Reduce TextFormFieldDemo and TextFormFieldDemoState to a single class. Weather a widget is Stateful or Stateless should be internal and should not need explicit declaration by extending a State class. State should be POJOs.

@huycozy huycozy added triage enhancement New feature or request and removed triage labels Jun 23, 2022
@darshankawar darshankawar removed the enhancement New feature or request label Jan 24, 2023
@darshankawar
Copy link
Member

/cc @guidezpl Wondering if this should remain in this repo or can be transferred to https://github.com/flutter/gallery/issues ?

@guidezpl
Copy link
Member

Hey, all gallery issues can be transferred over

@darshankawar
Copy link
Member

Thanks for confirming. Transferring this to dedicated repo.

@darshankawar darshankawar transferred this issue from flutter/flutter Jan 27, 2023
@guidezpl guidezpl added enhancement New feature or request P3 Priority 3 - Could have labels Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request P3 Priority 3 - Could have
Projects
None yet
Development

No branches or pull requests

4 participants