Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for HearthCommand #172

Open
chosww opened this issue Aug 4, 2022 · 0 comments
Open

Add unit test for HearthCommand #172

chosww opened this issue Aug 4, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@chosww
Copy link
Contributor

chosww commented Aug 4, 2022

Is your feature request related to a problem?

While I was working on task to add support for Livewire in Hearth, I had to update HearthCommand file. The update caused CodeCov CI check failure, because we are not testing HearthCommand.

Describe the solution you'd like

I found a doc for testing Command: https://laravelpackage.com/06-artisan-commands.html#testing-a-command. Initial approach would be follow the documentation.

Describe alternative solutions you've considered

Excluding HearthCommand from CodeCov would be a way to remove CodeCov complaint: https://phpunit.readthedocs.io/en/9.5/configuration.html#the-exclude-element.

@chosww chosww added the enhancement New feature or request label Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant