Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog: upgrade td-agent v4 to fluent-package v5 #266

Merged
merged 1 commit into from
Aug 28, 2023
Merged

blog: upgrade td-agent v4 to fluent-package v5 #266

merged 1 commit into from
Aug 28, 2023

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Jul 14, 2023

No description provided.

@kenhys kenhys force-pushed the upgrade-from-v4-to-v5 branch 6 times, most recently from 4d78437 to 6bffef0 Compare July 19, 2023 08:30
@kenhys kenhys marked this pull request as ready for review July 19, 2023 08:31
@kenhys
Copy link
Contributor Author

kenhys commented Jul 19, 2023

If release target day is determined, it should update the file name of blog entry.

@kenhys kenhys force-pushed the upgrade-from-v4-to-v5 branch 3 times, most recently from bb5c589 to 58a2951 Compare July 21, 2023 07:17
@kenhys kenhys force-pushed the upgrade-from-v4-to-v5 branch 2 times, most recently from 3d1706c to 1a8635e Compare August 3, 2023 05:32
@kenhys kenhys mentioned this pull request Aug 4, 2023
Merged
daipom
daipom reviewed Aug 4, 2023
View reviewed changes
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for summarizing this!
I have commented on some points.

content/blog/20230731_upgrade-td-agent-v4-to-v5.md Outdated Show resolved Hide resolved
content/blog/20230731_upgrade-td-agent-v4-to-v5.md Outdated Show resolved Hide resolved
content/blog/20230731_upgrade-td-agent-v4-to-v5.md Outdated Show resolved Hide resolved
content/blog/20230731_upgrade-td-agent-v4-to-v5.md Outdated Show resolved Hide resolved
@kenhys kenhys force-pushed the upgrade-from-v4-to-v5 branch 2 times, most recently from 2c12537 to 56a5aca Compare August 4, 2023 09:11
@kenhys kenhys mentioned this pull request Aug 7, 2023
Open
daipom
daipom approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!
When should we merge this?

@kenhys
Copy link
Contributor Author

kenhys commented Aug 9, 2023

When should we merge this?

When GA is ready to announce. (so tweak filename of this article later)

@kenhys
Copy link
Contributor Author

kenhys commented Aug 18, 2023

FIXME: replace "standard" phrase

@kenhys
Copy link
Contributor Author

kenhys commented Aug 18, 2023

@kenhys kenhys merged commit 23e420d into fluent:master Aug 28, 2023
1 check passed
@kenhys kenhys deleted the upgrade-from-v4-to-v5 branch August 28, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daipom daipom daipom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Fluentd Kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenhys @daipom