Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: v3.3.0 GitHub release missing setup.yaml asset #1495

Closed
OddBloke opened this issue Mar 7, 2025 · 7 comments
Closed

bug: v3.3.0 GitHub release missing setup.yaml asset #1495

OddBloke opened this issue Mar 7, 2025 · 7 comments

Comments

@OddBloke
Copy link

OddBloke commented Mar 7, 2025

Describe the issue

👋 Thanks for all the work that went into the 3.3.0 release!

Our automation is tripping over on the lack of a setup.yaml asset on the v3.3.0 release. It has two assets, the source code zip and tar.gz. Contrast this with v3.2.0 which has setup.yaml and fluent-operator.tgz (in addition to the two source code assets).

Is this still the appropriate place to pull setup.yaml from, or should we shift to a different source (the release tag itself, for example)?

To Reproduce

Fetch https://github.com/fluent/fluent-operator/releases/download/v3.3.0/setup.yaml

Expected behavior

The content at https://github.com/fluent/fluent-operator/blob/v3.3.0/manifests/setup/setup.yaml is downloaded.

Your Environment

- Fluent Operator version: N/A
- Container Runtime: N/A
- Operating system: N/A
- Kernel version: N/A

How did you install fluent operator?

No response

Additional context

No response

@cw-Guo
Copy link
Collaborator

cw-Guo commented Mar 7, 2025

@OddBloke We didn't mean to remove the setup.yaml.

cc @benjaminhuo I am not sure whether I have overlooked something during the release. Can you please help take a look at it?

@cw-Guo cw-Guo marked this as a duplicate of #1494 Mar 7, 2025
@truongnht
Copy link
Contributor

this issue blocks us from upgrading, since we dont have the required crds for the setup.

@joshuabaird
Copy link
Collaborator

@cw-Guo In RELEASE.md:

- Add file `setup.yaml` from `manifests/setup/setup.yaml` and then click "Publish release".

@cw-Guo
Copy link
Collaborator

cw-Guo commented Mar 11, 2025

@joshuabaird I added this setup.yaml and also upload the package of the helm chart. helm package charts/fluent-operator We might need to update the instructions, or maybe add some scripts to Makefile to automate this.

@OddBloke @truongnht please help check whether this has been fixed. Thanks.

@truongnht
Copy link
Contributor

sure, let me test and get back to you

@truongnht
Copy link
Contributor

I confirmed it working

@cw-Guo cw-Guo closed this as completed Mar 13, 2025
@cw-Guo
Copy link
Collaborator

cw-Guo commented Mar 13, 2025

  • improve the release document to include more steps for the release.
  • add more automation for releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants