Commit b69cea5
authored
Rubocop: Fix Bundler/OrderedGems and Performance/FluentdPluginLogStringInterpolation (#5)
This patch will fix following Rubocop's suggestions:
```
$ bundle exec rubocop
Inspecting 5 files
C...C
Offenses:
Gemfile:8:1: C: [Correctable] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem rubocop-fluentd should appear before test-unit.
gem "test-unit-rr", "~> 1.0.5" ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:9:1: C: [Correctable] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem rubocop-fluentd should appear before test-unit-rr.
gem "rubocop-fluentd", "~> 0.2.0"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/fluent/plugin/in_fluent_package_update_notifier.rb:75:11: C: Performance/FluentdPluginLogStringInterpolation: Use log.error { "..." } instead of log.error("...")
log.error "Failed to check updates: #{e.message}"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
5 files inspected, 3 offenses detected, 2 offenses autocorrectable
```1 parent 24156be commit b69cea5
File tree
2 files changed
+2
-2
lines changed- lib/fluent/plugin
2 files changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
| 75 | + | |
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
| |||
0 commit comments