Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: remove arg server from buf processes #139

Open
elgiano opened this issue Aug 17, 2022 · 1 comment
Open

Proposal: remove arg server from buf processes #139

elgiano opened this issue Aug 17, 2022 · 1 comment

Comments

@elgiano
Copy link
Contributor

elgiano commented Aug 17, 2022

I know this is a breaking interface change, but since it's impossible to have a buffer on one server and run the analysis on another, I think the server argument is redundant for all buffer processes. Such processes can get the server instance from the source buffer that gets passed to them:

// in, e.g. FluidBufMFCC.process
^this.new(src.server, nil, [features])
// instead of: ^this.new(server, nil,[features])

Since BufProcesses have already lots of args usually, I think that removing a redundant one would contribute to cleaner (e.g. more understandable/actionable) code

@weefuzzy
Copy link
Member

Good point (and I guess we should assert that the server for each passed Buffer actually matches). The scale of breakage will be pretty immense though, so I'd be inclined to think carefully about how / when such a change could be deployed. It might be more of a v2 thing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants