Skip to content

Commit a38df23

Browse files
committed
Fix misleading RFC 5970 comment in bootfile-url handling
The previous comment incorrectly suggested that the Boot File URL option in RFC 5970 limits the download protocol. While the RFC allows various protocols, the current implementation only supports TFTP. This patch updates the comment to clarify the current situation. Fixes: tianocore#10742 Signed-off-by: Andreas Florath <[email protected]>
1 parent bc664d1 commit a38df23

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -415,10 +415,16 @@ PxeBcExtractBootFileUrl (
415415
//
416416

417417
//
418-
// Based upon RFC 5970 and UEFI 2.6, bootfile-url format can be
419-
// tftp://[SERVER_ADDRESS]/BOOTFILE_NAME or tftp://domain_name/BOOTFILE_NAME
420-
// As an example where the BOOTFILE_NAME is the EFI loader and
421-
// SERVER_ADDRESS is the ASCII encoding of an IPV6 address.
418+
// According to RFC 5970, the Boot File URL option does not restrict the
419+
// download protocol, but only requires a valid URL. Although HTTP is
420+
// recommended for network booting, the URL may also follow a TFTP-style
421+
// format. This function expects URLs of the form:
422+
// protocol://[SERVER_ADDRESS]/BOOTFILE_NAME or
423+
// protocol://domain_name/BOOTFILE_NAME
424+
// where SERVER_ADDRESS is an ASCII-encoded IPv6 address and BOOTFILE_NAME
425+
// typically denotes the EFI loader.
426+
//
427+
// Note: Currently, only the TFTP protocol is implemented.
422428
//
423429
PrefixLen = (UINT16)AsciiStrLen (PXEBC_DHCP6_BOOT_FILE_URL_PREFIX);
424430

0 commit comments

Comments
 (0)