Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glm changed the way there structs are initialized #268

Open
mgerhardy opened this issue Aug 16, 2017 · 2 comments
Open

glm changed the way there structs are initialized #268

mgerhardy opened this issue Aug 16, 2017 · 2 comments
Labels

Comments

@mgerhardy
Copy link
Contributor

stuff like glm::rotate(glm::mat4(), [...] won't work anymore in future version of glm - you have to use the glsl call glm::mat4(1.0f) here, the same is true for stuff like glm::vec3() - this is no longer initialized to zero. I've seen this quite a lot over the codebase. So you might be interested in this fact. You still some time left until latest glm versions gets into the repositories - but still...

@mgerhardy
Copy link
Contributor Author

these might help to find some of the relevant locations.

ag "glm::?mat. [a-zA-Z]+;" src/
ag "glm::?vec. [a-zA-Z]+;" src/
ag "glm::?quat [a-zA-Z]+;" src/
ag "glm::?vec.\(\)" src/
ag "glm::?mat.\(\)" src/
ag "glm::?quat\(\)" src/

@floooh
Copy link
Owner

floooh commented Aug 16, 2017

Ok thanks for the heads up :) glm is in a submodule in fips-glm, so it won't break automatically even for new check-outs. I'm not sure yet when I will update glm to latest, but at least I know now what's the reason if everything suddenly breaks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants